Changeset 745

Timestamp:

01/16/08 01:42:54 (23 months ago)

Author:

ask

Message:

use a locally scoped filehandle instead of a typeglob in load_config()

(from Eamon Daly,
Message-Id: <037e01c857c5$2b7ceb80$69fea8c0@EDALYLAPTOP>)

Files:

• trunk/lib/Perlbal.pm (modified) (1 diff)

trunk/lib/Perlbal.pm

@@ -1160 +1160 @@
 sub load_config {
     my ($file, $writer) = @_;
-    open (F, $file) or die "Error opening config file ($file): $!\n";
+    open (my $fh, $file) or die "Error opening config file ($file): $!\n";
     my $ctx = Perlbal::CommandContext->new;
     $ctx->verbose(0);
-    while (my $line = <F>) {
+    while (my $line = <$fh>) {
         $line =~ s/\$(\w+)/$ENV{$1}/g;
         return 0 unless run_manage_command($line, $writer, $ctx);
     }
-    close(F);
+    close($fh);
     return 1;
 }