Changeset 526 for branches/reproxy-cache

Timestamp:

08/18/06 22:38:22 (4 years ago)

Author:

bradfitz

Message:

stats and a bug fix

Location:

branches/reproxy-cache/lib/Perlbal

Files:

• ClientProxy.pm (modified) (3 diffs)
• Service.pm (modified) (3 diffs)

branches/reproxy-cache/lib/Perlbal/ClientProxy.pm

@@ -740 +740 @@
 
     my $req_hd = $self->{req_headers};
-    my $cache  = $self->{service}->{reproxy_cache};
+    my $svc    = $self->{service};
+    my $cache  = $svc->{reproxy_cache};
+    $svc->{_stat_requests}++;
 
     my $requri   = $req_hd->request_uri    || '';
@@ -753 +755 @@
     return 0 if time() > $timeout;
 
+    $svc->{_stat_cache_hits}++;
     my %headers = map { ref $_ eq 'SCALAR' ? $$_ : $_ } @{$headers || []};
 
     if (my $ims = $req_hd->header("If-Modified-Since")) {
         my ($lm_key) = grep { uc($_) eq "LAST-MODIFIED" } keys %headers;
-        my $lm = $headers->{$lm_key} || "";
+        my $lm = $headers{$lm_key} || "";
 
         # remove the IE length suffix
@@ -765 +768 @@
         if ($ims eq $lm) {
             my $res_hd = Perlbal::HTTPHeaders->new_response(304);
+            $res_hd->header("Content-Length", "0");
             $self->tcp_cork(1);
             $self->state('xfer_resp');

branches/reproxy-cache/lib/Perlbal/Service.pm

@@ -90 +90 @@
             'error_retry_schedule',  # string of comma-separated seconds (full or partial) to delay between retries
             'latency',               # int: milliseconds of latency to add to request
+
+            # stats:
+            '_stat_requests',       # total requests to this service
+            '_stat_cache_hits',     # total requests to this service that were served via the reproxy-url cache
             );
 
@@ -1334 +1338 @@
 
     $out->("SERVICE $self->{name}");
-    $out->("     listening: $self->{listen}");
+    $out->("     listening: " . ($self->{listen} || "--"));
     $out->("          role: $self->{role}");
     if ($self->{role} eq "reverse_proxy" ||
@@ -1348 +1352 @@
     }
     if ($self->{role} eq "reverse_proxy") {
+        if ($self->{reproxy_cache}) {
+            my $hits     = $self->{_stat_cache_hits} || 0;
+            my $hit_rate = sprintf("%0.02f%%", eval { $hits / ($self->{_stat_requests} || 0) * 100 } || 0);
+            $out->("    cache hits: $hits");
+            $out->("cache hit rate: $hit_rate");
+        }
+
         my $bored_count = scalar @{$self->{bored_backends}};
         $out->(" connect-ahead: $bored_count/$self->{connect_ahead}");