Changeset 424

Timestamp:

08/23/05 18:31:17 (5 years ago)

Author:

bradfitz

Message:

-- webserver mode now ignores URL arguments when looking up

filename

Location:

trunk

Files:

• CHANGES (modified) (1 diff)
• doc/hacking/todo.txt (modified) (2 diffs)
• lib/Perlbal/ClientHTTPBase.pm (modified) (1 diff)
• t/15-webserver.t (modified) (2 diffs)

trunk/CHANGES

@@ +1 @@
+    -- webserver mode now ignores URL arguments when looking up
+       filename
+
     -- remove warnings accessing undefs in ranges and vhosts
 

trunk/doc/hacking/todo.txt

@@ -58 +58 @@
 * pidfile writing
 
-* --version / --help
-
 * acl stuff
 
@@ -68 +66 @@
 
 * ProxyPassReverse-like system
-
-* webserver mode doesn't chop of URL parameters

trunk/lib/Perlbal/ClientHTTPBase.pm

@@ -303 +303 @@
     my $uri = Perlbal::Util::durl($self->{replacement_uri} || $hd->request_uri);
 
+    # chop off the query string
+    $uri =~ s/\?.*//;
+
     # don't allow directory traversal
     if ($uri =~ /\.\./ || $uri !~ m!^/!) {

trunk/t/15-webserver.t

@@ -4 +4 @@
 use Perlbal::Test;
 
-use Test::More 'no_plan';
+use Test::More tests => 11;
 require HTTP::Request;
 
@@ -60 +60 @@
 ok(get($url) eq $contents, "GET request");
 
+# a get with URL parameters
+ok(get("$url?foo=bar") eq $contents, "GET request");
+
 # 404 path
 ok(! get("$url/404.txt"), "missing file");