Changeset 932

Timestamp:

08/07/08 23:50:46 (20 months ago)

Author:

mpaschal

Message:

Use INSERT with conflict resolution keywords where available
BugzID: 80826

Files:

• trunk/LinkedEntryCustomFields/plugins/LinkedEntryCustomFields/lib/LinkedEntryCustomFields/Convert.pm (modified) (2 diffs)

trunk/LinkedEntryCustomFields/plugins/LinkedEntryCustomFields/lib/LinkedEntryCustomFields/Convert.pm

@@ -26 +26 @@
     radio    => [ 'choices' ],
     entry    => [ qw( weblog category_ids ) ],
+);
+
+my %insert_statement_for_ddl_class = (
+    'MT::ObjectDriver::DDL::mysql'  => 'INSERT IGNORE INTO',
+    'MT::ObjectDriver::DDL::SQLite' => 'INSERT OR IGNORE INTO',
 );
 
@@ -284 +289 @@
                   ;
 
-    # TODO: we should ignore fields that are already set, using INSERT IGNORE
-    # on mysql or INSERT OR IGNORE on sqlite. but if we can't support it on
-    # the other drivers, should we bother? should we delete conflicting data
-    # first from mt_entry_meta so the insert should succeed?
+    # TODO: should we instead delete conflicting data from mt_entry_meta so
+    # an INSERT without IGNORE should succeed?
     # TODO: generic multidatabase support with ORM loop?
-    my $insert_sql = join q{ }, 'INSERT INTO', $meta_table,
+    my $insert_stmt = $insert_statement_for_ddl_class{ $dbd->ddl_class }
+        || 'INSERT INTO';  # we'll have to error if we can't ignore conflicts
+    my $insert_sql = join q{ }, $insert_stmt, $meta_table,
         '(', join(q{, }, @meta_fields), ')',
         'SELECT', $id_col, q{,}, q{?}, q{,},