Changeset 571 for branches/CustomFieldsUpgradeAssistant-bugfix

Timestamp:

03/20/08 03:08:27 (21 months ago)

Author:

fumiakiy

Message:

Moved bug-fixed code into the plugin so upgrade won't choke. The fix is in the next version of MT Professional, therefore the release of it will deprecate this branch.

Files:

• branches/CustomFieldsUpgradeAssistant-bugfix/plugins/CustomFields/customfields.pl (modified) (3 diffs)

branches/CustomFieldsUpgradeAssistant-bugfix/plugins/CustomFields/customfields.pl

@@ -12 +12 @@
 use MT::Util qw( escape_unicode );
 use CustomFields::Util qw( get_meta save_meta );
-use CustomFields::Upgrade;
 use CustomFields::Field;
 
@@ -263 +262 @@
     # Author CF is always in plugindata
     $upg->progress(_translate_escape('Moving metadata storage for users...'));
-    CustomFields::Upgrade::customfields_move_meta($upg, 'author');
+    customfields_move_meta_fixed($upg, 'author');
 
     # Process custom fields stored in plugindata
     # Category and folder stays in plugindata.
     $upg->progress(_translate_escape('Moving metadata storage for entries...'));
-    CustomFields::Upgrade::customfields_move_meta($upg, 'entry');
+    customfields_move_meta_fixed($upg, 'entry');
     $upg->progress(_translate_escape('Moving metadata storage for pages...'));
-    CustomFields::Upgrade::customfields_move_meta($upg, 'page');
+    customfields_move_meta_fixed($upg, 'page');
 
     # Process custom fields stored in custom tables
@@ -309 +308 @@
 }
 
+sub customfields_move_meta_fixed {
+    my $plugin = shift;
+    my ($obj_type) = @_;
+    # CF21b stores authors data as "_NN" ('author' isn't there)!
+    my $t = $obj_type eq 'author' ? q() : $obj_type;
+
+    require MT::PluginData;
+    my $pd_iter = MT::PluginData->load_iter(
+      {
+        plugin => 'CustomFields',
+        key => "${t}_%",
+      },
+      {
+        like => { key => 1 }
+      }
+    );
+
+    my @pd_ids;
+    while ( my $pd = $pd_iter->() ) {
+        if ( $pd->key =~ /^${t}_(\d+)$/ ) {
+            my $id = $1;
+            my $pd_data = $pd->data;
+            next unless $pd_data;
+            my $old_meta = $pd_data->{customfields};
+            unless ( $old_meta ) {
+                $old_meta = $pd_data;
+            }
+            my $obj = MT->model($obj_type)->load($id);
+            next unless $obj;
+            save_meta($obj, $old_meta);
+            push @pd_ids, $pd->id;
+        }
+    }
+
+    MT::PluginData->remove( { id => \@pd_ids } );
+    1;
+}
+
 1;