Changeset 185

Timestamp:

01/25/07 02:48:25 (3 years ago)

Author:

gboggs

Message:

Corrected the path in the copy operation. Made the module OO inheritable. Set the Id keywords.

Location:

trunk/tools/PluginBuilder

Files:

• lib/PluginBuilder.pm (modified) (5 diffs, 1 prop)
• plugin-builder.cgi (modified) (1 prop)
• plugin-builder.pl (modified) (2 diffs, 1 prop)
• t/podcoverage.t (modified) (2 diffs)

trunk/tools/PluginBuilder/lib/PluginBuilder.pm

@@ +1 @@
+# $Id$
+
 package PluginBuilder;
-our $VERSION = '0.00_4';
-# $Id$
+our $VERSION = '0.00_5';
 use strict;
 use warnings;
@@ -25 +26 @@
 
 sub new {
-    my $class = shift;
+    my $proto = shift;
+    my $class = ref $proto || $proto;
     my $self = {};
     bless $self, $class;
@@ -87 +89 @@
 
     eval{ GetOptions(%o) };  # Grab the command-line options.
-
-    # Gracefully bail-out if something went wrong.
+    # And gracefully bail-out if something went wrong.
     if( $@ || !${$o{'archive=s'}}   ||
               !${$o{'build-dir=s'}} ||
@@ -141 +142 @@
         # Populate the path with the files.
         for my $file ( @{ $self->{types}{$type}{files} } ) {
-            my $dest = File::Spec->catfile( $dir, scalar(fileparse($file)) );
+            my $dest = File::Spec->catfile( $path, scalar(fileparse($file)) );
             copy( $file, $dest ) or die "Can't copy $file, $dest: $!"
                 unless $self->{debug};
@@ -179 +180 @@
 =head2 new
 
+  PluginBuilder->new();
+
 Return a new C<PluginBuilder> object.
 

trunk/tools/PluginBuilder/plugin-builder.pl

@@ -3 +3 @@
 use strict;
 use warnings;
+
+# Run from the PluginBuilder directory or an MT directory with
+# PluginBuilder installed.
 use lib qw( lib plugins/tools/PluginBuilder/lib );
 use PluginBuilder;
 our $VERSION = $PluginBuilder::VERSION;
+
 my $p = PluginBuilder->new();
+
 $p->get_options();
+
 $p->build();
 
@@ -13 +19 @@
 =head1 NAME
 
-plugin-builder.pl - Command-line, Movable Type plugin stub builder
+plugin-builder.pl - Movable Type command-line plugin stub builder
 
 =head1 SYNOPSIS

trunk/tools/PluginBuilder/t/podcoverage.t

@@ -40 +40 @@
     my $pc = Pod::Coverage->new(
         package => $module,
-        trustme => $trustme,
-        pod_from => $pod_from,
+#        trustme => $trustme,
+#        pod_from => $pod_from,
     );
     my $coverage = $pc->coverage;
@@ -53 +53 @@
         $uncovered += $naked_count;
         is($coverage, 1, "$module: $cover_count/" . ($cover_count+$naked_count))
-            or diag("pod coverage is $c%. missing pod for: " . join(", ", sort @naked));
+            or diag($pc->why_unrated . " $c%. missing pod for: " . join(", ", sort @naked));
     } else {
         SKIP: { skip("$module: " . $pc->why_unrated, 1); }