Changeset 2665

Timestamp:

07/01/08 03:45:24 (12 months ago)

Author:

fumiakiy

Message:

Allow '0' as valid value for meta fields. BugId:80349

Files:

• branches/release-41/php/lib/mtdb_base.php (modified) (3 diffs)

branches/release-41/php/lib/mtdb_base.php

@@ -3076 +3076 @@
                 foreach ($cfrow as $cffield => $cfvalue) {
                     if (preg_match("/^${field_prefix}v/", $cffield)) {
-                        // FIXME: Some DBMS can't distinguish NULL from empty string.
-                        // Treat custom field that has empty string the same as field with no data.
-                        if (isset($cfvalue) && $cfvalue) {
+                        if (isset($cfvalue) && ( $cfvalue != '' )) {
                             $value = $cfvalue;
                             $field = $cffield;
@@ -3085 +3083 @@
                     }
                 }
-                if (isset($value)) {
+                if (isset($field)) {
                     if (preg_match("/_vblob$/", $field)) {
                         # unserialize blob if value is serialized
@@ -3095 +3093 @@
                         }
                     }
-                    $meta[$cfrow["${datasource}_meta_type"]] = $value;
-                }
+                }
+                $meta[$cfrow["${datasource}_meta_type"]] = $value;
             }
             $this->_meta_cache["${obj_type}_meta_${obj_id}"] = $meta;