Changeset 2660

Timestamp:

06/30/08 20:46:39 (20 months ago)

Author:

mpaschal

Message:

Some questions about this new code
BugzID: 80404

Files:

• branches/release-41/lib/MT/Upgrade.pm (modified) (4 diffs)

branches/release-41/lib/MT/Upgrade.pm

@@ -1011 +1011 @@
         next TYPE if !$class->has_meta();  # nothing to upgrade
 
+        # TODO: what is this supposed to mean?
         my $t = $type;
         my $class_type = $class->properties->{class_type};
@@ -1021 +1022 @@
             # If there's no appropriate superclass, go to update with the class
             # we have, not the class we want.
+            # TODO: if we're checking against the registry type without modifying it, why are we looking for a better object class first?
             next TYPE if $added_step{$type};  # already got that one
         }
@@ -1027 +1029 @@
         }
 
+        # TODO: why is this no longer the representative type for a table? that makes us upgrade tables multiple times
         my %step_param = ( type => $t );
+        # TODO: can't we just make this a different upgrade step?
         $step_param{plugindata} = 1
             if ( $class eq 'MT::Category' ) || ( $class eq 'MT::Folder' );
@@ -1125 +1129 @@
     my $stmt = $dbd->sql_class->new;
 
-    # assumes 'meta' is the meta column name; should be for all core types
-    # we are processing
     my $meta_col = $param{meta_column} || 'meta';