Changeset 2575

Timestamp:

06/13/08 23:38:01 (20 months ago)

Author:

bchoate

Message:

Fix for displaying publish error when saving a publishable comment. BugId:80094

Location:

branches/release-40/lib/MT

Files:

• App/CMS.pm (modified) (1 diff)
• CMS/Comment.pm (modified) (1 diff)

branches/release-40/lib/MT/App/CMS.pm

@@ -3174 +3174 @@
         require MT::Log;
         $app->log({
-            message => $app->translate("Error during publishing: [_1]", (defined $msg ? $msg : $app->errstr)),
+            message => (defined $msg ? $msg : $app->translate("Error during publishing: [_1]", $app->errstr)),
             class => "system",
             level => MT::Log::ERROR(),

branches/release-40/lib/MT/CMS/Comment.pm

@@ -1460 +1460 @@
     my $eh = shift;
     my ( $app, $obj, $original ) = @_;
+
     if ( $obj->visible
         || ( ( $obj->visible || 0 ) != ( $original->visible || 0 ) ) )
     {
-        $app->rebuild_entry( Entry => $obj->entry_id, BuildIndexes => 1 )
-            or return $app->publish_error();
+        return MT::Util::start_background_task(
+            sub {
+                my $app = MT->instance;
+                if ( !$app->rebuild_entry( Entry => $obj->entry_id, BuildIndexes => 1 ) ) {
+                    $app->publish_error(); # logs error as well.
+                    return $eh->error( MT->translate( "Publish failed: [_1]", $app->errstr ) );
+                }
+            }
+        );
     }
     1;