Changeset 2564

Timestamp:

06/13/08 03:20:08 (20 months ago)

Author:

fumiakiy

Message:

Do not proceed restoring from the backup which was from *different* version of MT (not just newer, but different version would not be allowed). BugId:80102

Location:

branches/release-40

Files:

• lib/MT/BackupRestore.pm (modified) (2 diffs)
• lib/MT/BackupRestore/BackupFileHandler.pm (modified) (2 diffs)
• lib/MT/CMS/Tools.pm (modified) (3 diffs)
• lib/MT/L10N/ja.pm (modified) (1 diff)
• tmpl/cms/restore.tmpl (modified) (2 diffs)

branches/release-40/lib/MT/BackupRestore.pm

@@ -334 +334 @@
     ); };
 
-    MT->run_callbacks('restore', $objects, $deferred, $errors, $callback);
+    unless ( $@ ) {
+        MT->run_callbacks('restore', $objects, $deferred, $errors, $callback);
+    }
     $$errormsg = join('; ', @$errors);
     ($deferred, $blog_ids);
@@ -433 +435 @@
     }
 
-    MT->run_callbacks('restore', \%objects, $deferred, $errors, $callback);
+    unless ( $@ ) {
+        MT->run_callbacks('restore', \%objects, $deferred, $errors, $callback);
+    }
     my $blog_ids = scalar(@blog_ids) ? \@blog_ids : undef;
     my $asset_ids = scalar(@asset_ids) ? \@asset_ids : undef;

branches/release-40/lib/MT/BackupRestore/BackupFileHandler.pm

@@ -42 +42 @@
         die MT->translate('Uploaded file was not a valid Movable Type backup manifest file.')
             if !(('movabletype' eq $name) && (MT::BackupRestore::NS_MOVABLETYPE() eq $ns));
-        unless ($self->{ignore_schema_conflicts}) {
+        #unless ($self->{ignore_schema_conflicts}) {
             my $schema = $attrs->{'{}schema_version'}->{Value};
-            if (('ignore' ne $self->{schema_version}) && ($schema > $self->{schema_version})) {
+            #if (('ignore' ne $self->{schema_version}) && ($schema > $self->{schema_version})) {
+            if ( $schema != $self->{schema_version} ) {
                 $self->{critical} = 1;
-                my $message = MT->translate('Uploaded file was backed up from Movable Type with the newer schema version ([_1]) than the one in this system ([_2]).  It is not safe to restore the file to this version of Movable Type.', MT::I18N::encode_text(MT::I18N::utf8_off($schema), 'utf-8'), $self->{schema_version});
+                my $message = MT->translate('Uploaded file was backed up from Movable Type but the different schema version ([_1]) from the one in this system ([_2]).  It is not safe to restore the file to this version of Movable Type.', MT::I18N::encode_text(MT::I18N::utf8_off($schema), 'utf-8'), $self->{schema_version});
                 MT->log({ 
                     message => $message,
@@ -55 +56 @@
                 die $message;
             }
-        }
+        #}
         $self->{start} = 0;
         return 1;

branches/release-40/lib/MT/CMS/Tools.pm

@@ -1597 +1597 @@
     my ( $fh, $errormsg ) = @_;
     my $q = $app->param;
-    my $schema_version =
-      $q->param('ignore_schema_conflict')
-      ? 'ignore'
-      : $app->config('SchemaVersion');
+    my $schema_version = $app->config->SchemaVersion;
+    #my $schema_version =
+    #  $q->param('ignore_schema_conflict')
+    #  ? 'ignore'
+    #  : $app->config('SchemaVersion');
     my $overwrite_template = $q->param('overwrite_global_templates') ? 1 : 0;
 
@@ -1655 +1656 @@
 
     my $q = $app->param;
-    my $schema_version =
-      $q->param('ignore_schema_conflict')
-      ? 'ignore'
-      : $app->config('SchemaVersion');
+    my $schema_version = $app->config->SchemaVersion;
+    #my $schema_version =
+    #  $q->param('ignore_schema_conflict')
+    #  ? 'ignore'
+    #  : $app->config('SchemaVersion');
 
     my $overwrite_template = $q->param('overwrite_global_templates') ? 1 : 0;
@@ -1764 +1766 @@
     $param->{last}        = scalar(@$files) ? 0 : ( scalar(@$assets) ? 0 : 1 );
     $param->{open_dialog} = 1;
-    $param->{schema_version} =
-      $q->param('ignore_schema_conflict')
-      ? 'ignore'
-      : $app->config('SchemaVersion');
+    $param->{schema_version} = $app->config->SchemaVersion;
+    #$param->{schema_version} =
+    #  $q->param('ignore_schema_conflict')
+    #  ? 'ignore'
+    #  : $app->config('SchemaVersion');
     $param->{overwrite_templates} = $q->param('overwrite_global_templates') ? 1 : 0;
 

branches/release-40/lib/MT/L10N/ja.pm

@@ -864 +864 @@
 
 ## lib/MT/BackupRestore/BackupFileHandler.pm
-        'Uploaded file was backed up from Movable Type with the newer schema version ([_1]) than the one in this system ([_2]).  It is not safe to restore the file to this version of Movable Type.' => 'アップロヌドされたファむルはこのシステムのバヌゞョン([_2])より新しいバヌゞョン([_1])でバックアップされおいたす。このファむルを䜿っお埩å
-ƒã™ã‚‹ã“ずは掚奚されたせん。',
+        'Uploaded file was backed up from Movable Type but the different schema version ([_1]) from the one in this system ([_2]).  It is not safe to restore the file to this version of Movable Type.' => 'アップロヌドされたファむルはこのシステムのバヌゞョン([_2])ずは異なるバヌゞョン([_1])でバックアップされおいたす。このファむルを䜿っお埩å
+ƒã™ã‚‹ã“ずはできたせん。',
         '[_1] is not a subject to be restored by Movable Type.' => '[_1]はMovable Typeで埩å
 ƒã™ã‚‹å¯Ÿè±¡ã«ã¯å«ãŸã‚ŒãŠã„たせん。',

branches/release-40/tmpl/cms/restore.tmpl

@@ -35 +35 @@
                 <input name="file" type="file" size="50" />
         </mtapp:setting>
+        <mt:ignore><!-- disable the feature to ignore schema conflict.
         <mtapp:setting
             id="ignore_schema_conflict"
@@ -43 +44 @@
                 <label for="ignore_schema_conflict"><__trans phrase="Ignore schema version conflicts"></label>
         </mtapp:setting>
+        --></mt:ignore>
         <mtapp:setting
             id="overwrite_global_templates"