Changeset 2505

Timestamp:

06/04/08 07:54:01 (17 months ago)

Author:

fumiakiy

Message:

Purge stale search cache after it finishes processing, and also periodically. BugId:79999

Location:

branches/release-39/lib/MT

Files:

• App/Search.pm (modified) (2 diffs)
• Cache/Null.pm (modified) (1 diff)
• Cache/Session.pm (modified) (8 diffs)
• Core.pm (modified) (2 diffs)
• Memcached.pm (modified) (1 diff)

branches/release-39/lib/MT/App/Search.pm

@@ -173 +173 @@
         return;
     }
-    $app->{cache_driver} = $cache_driver->new( ttl => $app->config->SearchCacheTTL );
+    $app->{cache_driver} = $cache_driver->new(
+        ttl => $app->config->SearchCacheTTL,
+        kind => 'CS',
+    );
 }
 
@@ -877 +880 @@
     my ( $cb, $app ) = @_;
     alarm(0) if $app->{__have_throttle};
+    if ( my $cache_driver = $app->{cache_driver} ) {
+        $cache_driver->purge_stale( 2 * $app->config->SearchCacheTTL );
+    }
     1;
 }

branches/release-39/lib/MT/Cache/Null.pm

@@ -54 +54 @@
 }
 
+sub purge_stale {
+    my MT::Cache::Null $self = shift;
+    return;
+}
+
 sub flush_all {
     my MT::Cache::Null $self = shift;

branches/release-39/lib/MT/Cache/Session.pm

@@ -14 +14 @@
     my (%param) = @_;
     $param{'ttl'} ||= 0;
+    $param{'kind'} ||= 'CO';
     my $self = bless \%param, $class;
     return $self;
@@ -25 +26 @@
     if ( $self->{ttl} ) {
         $record = MT::Session::get_unexpired_value(
-            $self->{ttl}, { id => $key, kind => 'CO' } );
+            $self->{ttl}, { id => $key, kind => $self->{kind} } );
     }
     else {
-        $record = MT::Session->load( { id => $key, kind => 'CO' } );
+        $record = MT::Session->load( { id => $key, kind => $self->{kind} } );
     }
     return unless $record;
@@ -38 +39 @@
     my @keys = @_;
 
-    my @tmp = MT::Session->load( { id => \@keys, kind => 'CO' } )
+    my @tmp = MT::Session->load( { id => \@keys, kind => $self->{kind} } )
         or return;
 
@@ -61 +62 @@
     my MT::Cache::Session $self = shift;
     my ($key, $time) = @_;
-    MT::Session->remove( { id => $key, kind => 'CO' } )
+    MT::Session->remove( { id => $key, kind => $self->{kind} } )
         or return 0;
     1;
@@ -86 +87 @@
     my $cache = MT::Session->load({
         id   => $key,
-        kind => 'CO',
+        kind => $self->{kind},
     });
     $cache->remove() if $cache;
@@ -92 +93 @@
     $cache->set_values({
         id    => $key,
-        kind  => 'CO',
+        kind  => $self->{kind},
         start => time,
         data  => $val,
@@ -101 +102 @@
 sub flush_all {
     my MT::Cache::Session $self = shift;
-    MT::Session->remove({ kind => 'CO' });
+    MT::Session->remove({ kind => $self->{kind} });
+}
+
+sub purge_stale {
+    my MT::Cache::Session $self = shift;
+    my ( $ttl ) = @_;
+    MT::Session->remove(
+        { kind => $self->{kind}, start => [ undef, time - $ttl ] },
+        { range => { start => 1 } }
+    );
+    1;
 }
 
@@ -150 +161 @@
 Empty all the caches.
 
+=head2 $cache->purge_stale
+
+Deletes all the cached objects that are already too old.
+Takes one argument: $ttl specifies the duration that is considered stale.
+
 =head1 AUTHOR & COPYRIGHT
 

branches/release-39/lib/MT/Core.pm

@@ -774 +774 @@
             },
         },
+        'RemoveExpiredSearchCaches' => {
+            label => 'Remove Expired Search Caches',
+            frequency => 60 * 60 * 24,   # once a day
+            code => sub {
+                MT::Core->remove_expired_search_caches;
+            },
+        },
     };
 }
@@ -803 +810 @@
         $s->remove if !$s->get('remember');
     }
+    return '';
+}
+
+sub remove_expired_search_caches {
+    require MT::Session;
+
+    MT::Session->remove(
+        { kind => 'CS', start => [ undef, time - 60 * 60 ] },
+        { range => { start => 1 } } );
     return '';
 }

branches/release-39/lib/MT/Memcached.pm

@@ -51 +51 @@
         $driver_class->disconnect_all;
     }
+}
+
+# method for MT::Cache interface
+sub purge_stale {
+    1;
 }