Changeset 2475

Timestamp:

06/02/08 02:15:39 (21 months ago)

Author:

fumiakiy

Message:

Group_by methods now returns an iterator that can be finished early. BugId:79888

Location:

branches/release-39

Files:

• lib/MT/ObjectDriver/Driver/DBI.pm (modified) (1 diff)
• t/41-atom.t (modified) (2 diffs)
• t/driver-tests.pl (modified) (2 diffs)

branches/release-39/lib/MT/ObjectDriver/Driver/DBI.pm

@@ -201 +201 @@
     my $i = 0;
     return sub {
+        if (@_ && ($_[0] eq 'finish')) {
+            if ($sth) {
+                $sth->finish;
+                $driver->end_query($sth);
+            }
+            undef $sth;
+            return;
+        }
+
         unless ($sth->fetch && defined $count && (!defined $limit || ($i < $limit))) {
             $sth->finish;

branches/release-39/t/41-atom.t

@@ -416 +416 @@
     #print "$_\n" foreach @{$p->query_log};
     my ( $count, $eid ) = $iter->();
-    # finish iterator cleanly
-    while ( my @dump = $iter->() ) {}
+    $iter->('finish');
 
     my $entry = MT::Entry->load($eid);
@@ -575 +574 @@
         }
     }
-    # finish iterator cleanly
-    while ( my @dump = $iter->() ) {}
+    $iter->('finish');
     die unless $eid;
 

branches/release-39/t/driver-tests.pl

@@ -404 +404 @@
     }, {
         group => [ 'foo_id' ],
-        sort => 'foo_id desc',
+        sort => 'foo_id',
+        direction => 'descend',
     });
 my ($count, $bfid, $month);
@@ -418 +419 @@
 $cgb_iter = Bar->count_group_by(undef, {
         group => [ 'extract(month from created_on)' ],
-        sort => 'extract(month from created_on) desc',
+        sort => 'extract(month from created_on)',
+        direction => 'descend',
     });
 isa_ok($cgb_iter, 'CODE');