Changeset 2403

Timestamp:

05/20/08 20:16:24 (21 months ago)

Author:

bchoate

Message:

Updates to fix magic token parameter for edit profile. BugId:79822

Location:

branches/release-38

Files:

• lib/MT/App/Comments.pm (modified) (10 diffs)
• tmpl/comment/profile.tmpl (modified) (1 diff)

branches/release-38/lib/MT/App/Comments.pm

@@ -103 +103 @@
 # one already exists corresponding to the browser's session.
 #
-# Returns a pair ($session_key, $commenter) where $session_key is the
-# key to the MT::Session object (as well as the cookie value) and
-# $commenter is an MT::Author record. Both values are undef when no
-# session is active.
+# Returns a pair ($session_obj, $commenter) where $session_obj is
+# a MT::Session object and $commenter is an MT::Author record. Both
+# values are undef when no session is active.
 #
 sub _get_commenter_session {
@@ -153 +152 @@
 
     # session is valid!
-    return ( $session_key, $user );
+    return ( $sess_obj, $user );
 }
 
@@ -860 +859 @@
     # validate session parameter
     if ( my $sid = $q->param('sid') ) {
-        my ( $session, $commenter ) = $app->_get_commenter_session();
-        if ( $session && $commenter && ( $session eq $sid ) ) {
+        my ( $sess_obj, $commenter ) = $app->_get_commenter_session();
+        if ( $sess_obj && $commenter && ( $sess_obj->id eq $sid ) ) {
             # well, everything is okay
         } else {
@@ -1233 +1232 @@
     my $nick  = $q->param('author');
     my $email = $q->param('email');
-    my ( $session, $commenter );
+    my ( $sess_obj, $commenter );
     if ( $blog->accepts_registered_comments ) {
-        ( $session, $commenter ) = $app->_get_commenter_session();
+        ( $sess_obj, $commenter ) = $app->_get_commenter_session();
     }
     if ( $commenter && ( 'do_reply' ne $app->mode ) ) {
@@ -1455 +1454 @@
     my $c;
     if ( $blog_id && $blog ) {
-        my ( $session, $commenter ) = $app->_get_commenter_session();
-        if ( $session && $commenter ) {
+        my ( $sessobj, $commenter ) = $app->_get_commenter_session();
+        if ( $sessobj && $commenter ) {
             my $blog_perms = $commenter->blog_perm($blog_id);
             my $banned = $commenter->is_banned($blog_id) ? "1" : "0";
@@ -1462 +1461 @@
             $banned ||= 1 if $commenter->status == MT::Author::BANNED();
 
-            my $sessobj = MT::Session->load( $session );
             if ($banned) {
                 $sessobj->remove;
@@ -1746 +1744 @@
     my $app = shift;
 
-    my ( $session, $commenter ) = $app->_get_commenter_session();
+    my ( $sess_obj, $commenter ) = $app->_get_commenter_session();
     if ($commenter) {
         my $url;
@@ -1760 +1758 @@
         }
 
-        #require MT::Auth;
-        #my $ctx = MT::Auth->fetch_credentials( { app => $app } );
-        #my $cmntr_sess =
-        #  $app->session_user( $commenter, $ctx->{session_id},
-        #    permanent => $ctx->{permanent} );
-        #return $app->handle_error( $app->translate('Invalid login') )
-        #  unless $cmntr_sess;
-
         my $blog_id = $app->param('blog_id');
+        $app->{session} = $sess_obj;
         $app->user($commenter);
         my $param = {
@@ -1791 +1782 @@
     my $q   = $app->param;
 
+    my ( $sess_obj, $cmntr ) = $app->_get_commenter_session();
+    return $app->handle_error( $app->translate('Invalid login') )
+        unless $cmntr;
+
     my %param =
       map { $_ => scalar( $q->param($_) ) }
-      qw( id name nickname email password pass_verify hint url entry_url return_url external_auth);
-
-    unless ( $param{id} =~ /\d+/ ) {
-        $param{error} = $app->translate('Invalid commenter ID');
-        return $app->build_page( 'profile.tmpl', \%param );
-    }
-
-    my $cmntr = MT::Author->load( $param{id} );
-    unless ($cmntr) {
-        $param{error} = $app->translate('Invalid commenter ID');
-        return $app->build_page( 'profile.tmpl', \%param );
-    }
+      qw( name nickname email password pass_verify hint url entry_url return_url external_auth);
 
     $param{ 'auth_mode_' . $cmntr->auth_type } = 1;
 
-    # require MT::Auth;
-    # my $ctx = MT::Auth->fetch_credentials( { app => $app } );
-    # my $cmntr_sess =
-    #  $app->session_user( $cmntr, $ctx->{session_id},
-    #    permanent => $ctx->{permanent} );
-    # return $app->handle_error( $app->translate('Invalid login') )
-    #  unless $cmntr_sess;
-
     $app->user($cmntr);
+    $app->{session} = $sess_obj;
+
     $app->validate_magic
       or return $app->handle_error( $app->translate('Invalid request') );
@@ -1860 +1838 @@
         $app->make_commenter_session( $cmntr );
     }
+    $param{magic_token} = $app->current_magic;
 
     return $app->build_page( 'profile.tmpl', \%param );

branches/release-38/tmpl/comment/profile.tmpl

@@ -22 +22 @@
 <input type="hidden" name="__mode" value="save_profile" />
 <input type="hidden" name="magic_token" value="<mt:var name="magic_token">" />
-<input type="hidden" name="id" value="<mt:var name="id" escape="html">" />
 <input type="hidden" name="entry_url" value="<mt:var name="entry_url" escape="html">" />
 <input type="hidden" name="return_url" value="<mt:var name="return_url" escape="html">" />