Changeset 2314

Timestamp:

05/13/08 17:43:45 (21 months ago)

Author:

bchoate

Message:

Weaken category parent/children references cached in a category object. BugId:79687

Files:

• branches/release-38/lib/MT/Category.pm (modified) (7 diffs)

branches/release-38/lib/MT/Category.pm

@@ -9 +9 @@
 use strict;
 use base qw( MT::Object );
+use MT::Util qw( weaken );
 
 use MT::Blog;
@@ -76 +77 @@
     return $cat->{__path} if exists $cat->{__path};
     my $result = $cat->basename;
+    my $orig = $cat;
     do {
-        # TODO: uh, does this not mean we cache the resulting path on the
-        # root category object instead?
         $cat = $cat->parent ? __PACKAGE__->load($cat->parent) : undef;
         $result = join "/", $cat->basename, $result if $cat;
@@ -84 +84 @@
     # caching this information may be problematic IF
     # parent category basenames are changed.
-    $cat->{__path} = $result;
+    $orig->{__path} = $result;
 }
 *category_path = \&publish_path;
@@ -92 +92 @@
     return $cat->{__label_path} if exists $cat->{__label_path};
     my $result = $cat->label =~ m!/! ? '[' . $cat->label . ']' : $cat->label;
+    my $orig = $cat;
     do {
         $cat = $cat->parent ? __PACKAGE__->load($cat->parent) : undef;
@@ -99 +100 @@
     # caching this information may be problematic IF
     # parent category labels are changed.
-    $cat->{__label_path} = $result;
+    $orig->{__label_path} = $result;
 }
 
@@ -389 +390 @@
     unless ($cat->{__parent_category}) {
         $cat->{__parent_category} = ($cat->parent) ? $class->load($cat->parent) : undef;
+        weaken( $cat->{__parent_category} );
     }
     $cat->{__parent_category};
@@ -400 +402 @@
         $class->load({ blog_id => $cat->blog_id,
             parent => $cat->id });
+        weaken( $_ ) foreach @{ $cat->{__children} };
     }
     @{$cat->{__children}};