Changeset 1926

Timestamp:

04/16/08 10:50:21 (22 months ago)

Author:

takayama

Message:

Fixed BugId:76389
* Loop tags does not add 'glue', if row in loop tag was empty

• MTFor
• MTLoop
• MTTags
• MTEntryTags
• MTEntries
• MTEntryCategories
• MTCategories
• MTEntryAdditionalCategories
• MTParentCategories
• MTAssetTags
• MTPagerBlock

Location:

branches/release-35

Files:

• lib/MT/Template/ContextHandlers.pm (modified) (21 diffs)
• php/lib/MTUtil.php (modified) (1 diff)
• php/lib/block.mtassettags.php (modified) (4 diffs)
• php/lib/block.mtcategories.php (modified) (4 diffs)
• php/lib/block.mtentries.php (modified) (3 diffs)
• php/lib/block.mtentryadditionalcategories.php (modified) (3 diffs)
• php/lib/block.mtentrycategories.php (modified) (3 diffs)
• php/lib/block.mtentrytags.php (modified) (4 diffs)
• php/lib/block.mtfor.php (modified) (4 diffs)
• php/lib/block.mtloop.php (modified) (4 diffs)
• php/lib/block.mtparentcategories.php (modified) (4 diffs)
• php/lib/block.mttags.php (modified) (3 diffs)

branches/release-35/lib/MT/Template/ContextHandlers.pm

@@ -1324 +1324 @@
     my $vars = $ctx->{__stash}{vars} ||= {};
     my $glue = $args->{glue};
-    $glue = '' unless defined $glue;
     my $var = $args->{var};
     for (my $i = $start; $i <= $end; $i += $incr) {
@@ -1336 +1335 @@
         my $res = $builder->build($ctx, $tokens, $cond);
         return $ctx->error($builder->errstr) unless defined $res;
-        if ($res ne '') {
-            $out .= $glue if $cnt > 1;
-            $out .= $res;
-            $cnt++;
-        }
+        $out .= $glue
+            if defined $glue && $cnt > 1 && length($out) && length($res);
+        $out .= $res;
+        $cnt++;
     }
     return $out;
@@ -1590 +1588 @@
     my $vars = $ctx->{__stash}{vars} ||= {};
     my $glue = $args->{glue};
-    $glue = '' unless defined $glue;
     foreach my $item (@$var) {
         local $vars->{__first__} = $i == 1;
@@ -1625 +1622 @@
         return $ctx->error($builder->errstr) unless defined $res;
         if ($res ne '') {
-            $out .= $glue if $i > 1;
+            $out .= $glue if defined $glue && $i > 1 && length($out) && length($res);
             $out .= $res;
             $i++;
@@ -1916 +1913 @@
     my $tokens = $ctx->stash('tokens');
     my $needs_entries = (($ctx->stash('uncompiled') || '') =~ /<MT:?Entries/i) ? 1 : 0;
-    my $glue = $args->{glue} || '';
+    my $glue = $args->{glue};
     my $res = '';
     local $ctx->{__stash}{all_tag_count} = undef;
@@ -1974 +1971 @@
         defined(my $out = $builder->build($ctx, $tokens, $cond))
             or return $ctx->error( $builder->errstr );
-        $res .= $glue if $res ne '';
+        $res .= $glue if defined $glue && length($res) && length($out);
         $res .= $out;
     }
@@ -2097 +2094 @@
     my $entry = $ctx->stash('entry');
     return '' unless $entry;
-    my $glue = $args->{glue} || '';
+    my $glue = $args->{glue};
 
     local $ctx->{__stash}{tag_max_count} = undef;
@@ -2113 +2110 @@
         defined(my $out = $builder->build($ctx, $tokens, $cond))
             or return $ctx->error( $builder->errstr );
-        $res .= $glue if $res ne '';
+        $res .= $glue if defined $glue && length($res) && length($out);
         $res .= $out;
     }
@@ -4229 +4226 @@
         return $ctx->error( $builder->errstr ) unless defined $out;
         $last_day = $this_day;
-        $res .= $glue if defined $glue && $i;
+        $res .= $glue if defined $glue && $i && length($res) && length($out);
         $res .= $out;
         $i++;
@@ -4739 +4736 @@
     my $builder = $ctx->stash('builder');
     my $tokens = $ctx->stash('tokens');
-    my @res;
+    my $res;
+    my $glue = $args->{glue};
     for my $cat (@$cats) {
         local $ctx->{__stash}->{category} = $cat;
         defined(my $out = $builder->build($ctx, $tokens, $cond))
             or return $ctx->error( $builder->errstr );
-        push @res, $out if $out ne '';
-    }
-    my $sep = $args->{glue} || '';
-    join $sep, @res;
+        $res .= $glue if defined $glue && length($res) && length($out);
+        $res .= $out;
+    }
+    $res;
 }
 
@@ -6314 +6312 @@
     my $builder = $ctx->stash('builder');
     my $tokens = $ctx->stash('tokens');
-    my $glue = exists $args->{glue} ? $args->{glue} : '';
+    my $glue = $args->{glue};
     ## In order for this handler to double as the handler for
     ## <MTArchiveList archive_type="Category">, it needs to support
@@ -6356 +6354 @@
               ArchiveListFooter => $last }))
             or return $ctx->error( $builder->errstr );
-        $res .= $glue if $res ne '';
+        $res .= $glue if defined $glue && length($res) && length($out);
         $res .= $out;
         $cat = $next_cat;
@@ -6637 +6635 @@
     my $builder = $ctx->stash('builder');
     my $tokens = $ctx->stash('tokens');
-    my @res;
+    my $res;
+    my $glue = $args->{glue};
     for my $cat (@$cats) {
         next if $e->category && ($cat->label eq $e->category->label);
@@ -6643 +6642 @@
         defined(my $out = $builder->build($ctx, $tokens, $cond))
             or return $ctx->error( $builder->errstr );
-        push @res, $out;
-    }
-    my $sep = $args->{glue} || '';
-    join $sep, @res; 
+        $res .= $glue if defined $glue && length($res) && length($out);
+        $res .= $out if length($out);
+    }
+    $res;
 }
 
@@ -7189 +7188 @@
     # Get the arguments
     my $exclude_current = $args->{'exclude_current'};
-    my $glue = $args->{'glue'} || '';
+    my $glue = $args->{'glue'};
 
     # Get the current category
@@ -7196 +7195 @@
     return '' if ($cat eq '');
 
-    my @res;
+    my $res;
 
     # Put together the list of parent categories
@@ -7211 +7210 @@
             $out = 'cat-' . $c->id;
         }
-        push @res, $out;
-    }
-
-    # Slap them all together with some glue
-    return join $glue, @res;
+        $res .= $glue if defined $glue && length($res) && length($out);
+        $res .= $out if length($out);
+    }
+    $res;
 }
 
@@ -7922 +7920 @@
     my $asset = $ctx->stash('asset');
     return '' unless $asset;
-    my $glue = $args->{glue} || '';
+    my $glue = $args->{glue};
 
     local $ctx->{__stash}{tag_max_count} = undef;
@@ -7943 +7941 @@
         defined(my $out = $builder->build($ctx, $tokens, $cond))
             or return $ctx->error( $builder->errstr );
-        $res .= $glue if $res ne '';
+        $res .= $glue if defined $glue && length($res) && length($out);
         $res .= $out;
     }
@@ -8850 +8848 @@
 
     my $glue = $args->{glue};
-    $glue = q() unless defined $glue;
 
     my $output = q();
@@ -8868 +8865 @@
             }
             )) or return $ctx->error( $build->errstr );
-        $output .= $glue if $i > 1;
+        $output .= $glue if defined $glue && $i > 1 && length($output) && length($out);
         $output .= $out;
     }

branches/release-35/php/lib/MTUtil.php

@@ -891 +891 @@
         if ($ctx->stash('entry')) {
             $entry = $ctx->stash('entry');
+            if (empty($entry['placement_category_id']))
+                return null;
             if ($class == 'folder')
                 $cat = $ctx->mt->db->fetch_folder($entry['placement_category_id']);

branches/release-35/php/lib/block.mtassettags.php

@@ -7 +7 @@
 
 function smarty_block_mtassettags($args, $content, &$ctx, &$repeat) {
-    $localvars = array('_tags', 'Tag', '_tags_counter', 'tag_min_count', 'tag_max_count','all_tag_count');
+    $localvars = array('_tags', 'Tag', '_tags_counter', 'tag_min_count', 'tag_max_count','all_tag_count', '__out');
     if (!isset($content)) {
         $ctx->localize($localvars);
@@ -32 +32 @@
         if (!is_array($tags)) $tags = array();
         $ctx->stash('_tags', $tags);
+        $ctx->stash('__out', false);
         
         $counter = 0;
@@ -37 +38 @@
         $tags = $ctx->stash('_tags');
         $counter = $ctx->stash('_tags_counter');
+        $out = $ctx->stash('__out');
     }
     if ($counter < count($tags)) {
@@ -43 +45 @@
         $ctx->stash('_tags_counter', $counter + 1);
         $repeat = true;
-        if (($counter > 0) && isset($args['glue'])) {
-            $content = $content . $args['glue'];
+        if (isset($args['glue']) && !empty($content)) {
+            if ($out)
+                $content = $args['glue'] . $content;
+            else
+                $ctx->stash('__out', true);
         }
     } else {
+        if (isset($args['glue']) && $out && !empty($content))
+            $content = $args['glue'] . $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtcategories.php

@@ -9 +9 @@
     // status: incomplete
     // parameters: show_empty
-    $localvars = array('_categories', '_categories_counter', 'category', 'inside_mt_categories', 'entries', '_categories_glue', 'blog_id', 'blog');
+    $localvars = array('_categories', '_categories_counter', 'category', 'inside_mt_categories', 'entries', '_categories_glue', 'blog_id', 'blog', '__out');
     if (!isset($content)) {
         $ctx->localize($localvars);
@@ -19 +19 @@
         $ctx->stash('inside_mt_categories', 1);
         $ctx->stash('show_empty', isset($args['show_empty']) ? $args['show_empty'] : '0');
+        $ctx->stash('__out', false);
         $counter = 0;
     } else {
@@ -24 +25 @@
         $counter = $ctx->stash('_categories_counter');
         $glue = $ctx->stash('_categories_glue');
+        $out =$ctx->stash('__out');
     }
     if ($counter < count($categories)) {
@@ -35 +37 @@
         $ctx->stash('blog',
             $ctx->mt->db->fetch_blog($category['category_blog_id']));
-        if ($counter > 0) $content = $content . $glue;
+        if (!empty($glue) && !empty($content)) {
+            if ($out)
+                $content = $glue . $content;
+            else
+                $ctx->stash('__out', true);
+        }
         $repeat = true;
     } else {
+        if (!empty($glue) && $out && !empty($content))
+            $content = $glue . $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtentries.php

@@ -7 +7 @@
 
 function smarty_block_mtentries($args, $content, &$ctx, &$repeat) {
-    $localvars = array('entry', '_entries_counter','entries','current_timestamp','modification_timestamp','_entries_lastn', 'current_timestamp_end', 'DateHeader', 'DateFooter', '_entries_glue', 'blog', 'blog_id', 'conditional', 'else_content');
+    $localvars = array('entry', '_entries_counter','entries','current_timestamp','modification_timestamp','_entries_lastn', 'current_timestamp_end', 'DateHeader', 'DateFooter', '_entries_glue', 'blog', 'blog_id', 'conditional', 'else_content', '__out');
     if (isset($args['sort_by']) && $args['sort_by'] == 'score' && !isset($args['namespace'])) {
         return $ctx->error($ctx->mt->translate('sort_by="score" must be used in combination with namespace.'));
@@ -29 +29 @@
         $lastn = $args['lastn'];
         $ctx->stash('_entries_lastn', $lastn);
+        $ctx->stash('__out', false);
     } else {
         $lastn = $ctx->stash('_entries_lastn');
         $counter = $ctx->stash('_entries_counter');
+        $out = $ctx->stash('__out');
     }
     if (!isset($args['class'])) {
@@ -119 +121 @@
         $_REQUEST['entry_ids_published'][$entry['entry_id']] = 1;
         $glue = $ctx->stash('_entries_glue');
-        if ($glue != '') $content = $content . $glue;
+        if (isset($glue) && !empty($content)) {
+            if ($out)
+                $content = $glue . $content;
+            else
+                $ctx->stash('__out', true);
+        }
         $repeat = true;
     } else {
+        $glue = $ctx->stash('_entries_glue');
+        if (isset($glue) && $out && !empty($content))
+            $content = $glue . $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtentryadditionalcategories.php

@@ -7 +7 @@
 
 function smarty_block_mtentryadditionalcategories($args, $content, &$ctx, &$repeat) {
-    $localvars = array('_categories', 'category', '_categories_counter');
+    $localvars = array('_categories', 'category', '_categories_counter', '__out');
     if (!isset($content)) {
         $ctx->localize($localvars);
@@ -23 +23 @@
         }
         $ctx->stash('_categories', $categories);
+        $ctx->stash('__out', false);
         $counter = 0;
     } else {
         $categories = $ctx->stash('_categories');
         $counter = $ctx->stash('_categories_counter');
+        $out = $ctx->stash('__out');
     }
     if ($counter < count($categories)) {
@@ -33 +35 @@
         $ctx->stash('_categories_counter', $counter + 1);
         $repeat = true;
-        if (($counter > 0) && isset($args['glue'])) {
-            $content = $content . $args['glue'];
+        if (isset($args['glue']) && !empty($content)) {
+            if ($out)
+                $content = $args['glue'] . $content;
+            else
+                $ctx->stash('__out', true);
         }
     } else {
+        if (isset($args['glue']) && $out && !empty($content))
+            $content = $args['glue'] . $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtentrycategories.php

@@ -7 +7 @@
 
 function smarty_block_mtentrycategories($args, $content, &$ctx, &$repeat) {
-    $localvars = array('_categories', 'category', '_categories_counter');
+  $localvars = array('_categories', 'category', '_categories_counter', '__out');
     if (!isset($content)) {
         $ctx->localize($localvars);
@@ -14 +14 @@
         $categories = $ctx->mt->db->fetch_categories($args);
         $ctx->stash('_categories', $categories);
+        $ctx->stash('__out', false);
         $counter = 0;
     } else {
         $categories = $ctx->stash('_categories');
         $counter = $ctx->stash('_categories_counter');
+        $out = $ctx->stash('__out');
     }
     if ($counter < count($categories)) {
@@ -24 +26 @@
         $ctx->stash('_categories_counter', $counter + 1);
         $repeat = true;
-        if (($counter > 0) && isset($args['glue'])) {
-            $content = $content . $args['glue'];
+        if (isset($args['glue']) && !empty($content)) {
+            if ($out)
+                $content = $args['glue'] . $content;
+            else
+                $ctx->stash('__out', true);
         }
     } else {
+        if (isset($args['glue']) && $out && !empty($content))
+            $content = $args['glue'] . $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtentrytags.php

@@ -7 +7 @@
 
 function smarty_block_mtentrytags($args, $content, &$ctx, &$repeat) {
-    $localvars = array('_tags', 'Tag', '_tags_counter', 'tag_min_count', 'tag_max_count','all_tag_count');
+    $localvars = array('_tags', 'Tag', '_tags_counter', 'tag_min_count', 'tag_max_count','all_tag_count', '__out');
     if (!isset($content)) {
         $class = 'entry';
@@ -37 +37 @@
         if (!is_array($tags)) $tags = array();
         $ctx->stash('_tags', $tags);
+        $ctx->stash('__out', false);
         
         $counter = 0;
@@ -42 +43 @@
         $tags = $ctx->stash('_tags');
         $counter = $ctx->stash('_tags_counter');
+        $out = $ctx->stash('__out');
     }
     if ($counter < count($tags)) {
@@ -48 +50 @@
         $ctx->stash('_tags_counter', $counter + 1);
         $repeat = true;
-        if (($counter > 0) && isset($args['glue'])) {
-            $content = $content . $args['glue'];
+        if (isset($args['glue']) && !empty($content)) {
+            if ($out)
+                $content = $args['glue']. $content;
+            else
+                $ctx->stash('__out', true);
         }
     } else {
+        if (isset($args['glue']) && $out && !empty($content))
+            $content = $args['glue']. $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtfor.php

@@ -7 +7 @@
 
 function smarty_block_mtfor($args, $content, &$ctx, &$repeat) {
-    $localvars = array('__for_end', '__for_var');
+    $localvars = array('__for_end', '__for_var', '__out');
 
     if (!isset($content)) {
@@ -30 +30 @@
         $ctx->stash('__for_end', $end);
         $ctx->stash('__for_var', $var);
+        $ctx->stash('__out', false);
     } else {
         $index = $ctx->__stash['vars']['__index__'] + 1;
@@ -35 +36 @@
         $end = $ctx->stash('__for_end');
         $var = $ctx->stash('__for_var');
+        $out = $ctx->stash('__out');
     }
 
@@ -46 +48 @@
         if ($var)
             $ctx->__stash['vars'][$var] = $index;
-        if (array_key_exists('glue', $args)) {
-            if ($index < $end)
-                $content = $content . $args['glue'];
+        if (isset($args['glue']) && !empty($content)) {
+            if ($out)
+                $content = $args['glue'] . $content;
+            else
+                $ctx->stash('__out', true);
         }
         $repeat = true;
     } else {
+        if (isset($args['glue']) && $out && !empty($content))
+            $content = $args['glue'] . $content;
         $ctx->restore($localvars);
         $repeat = false;

branches/release-35/php/lib/block.mtloop.php

@@ -7 +7 @@
 
 function smarty_block_mtloop($args, $content, &$ctx, &$repeat) {
-    $localvars = array('__loop_keys', '__loop_values');
+    $localvars = array('__loop_keys', '__loop_values', '__out');
 
     if (!isset($content)) {
@@ -67 +67 @@
         $counter = 1;
         $ctx->stash('__loop_values', $value);
+        $ctx->stash('__out', false);
     }
     else {
@@ -72 +73 @@
         $keys = $ctx->stash('__loop_keys');
         $value = $ctx->stash('__loop_values');
+        $out = $ctx->stash('__out');
         if (!isset($keys) || $keys == 0) {
             $ctx->restore($localvars);
             $repeat = false;
+            if (isset($args['glue']) && $out && !empty($content))
+                $content = $args['glue'] . $content;
             return $content;
         }
@@ -97 +101 @@
         }
     }
-    if (array_key_exists('glue', $args)) {
-        if (1 < $counter)
-            $content = $content . $args['glue'];
+    if (isset($args['glue']) && !empty($content)) {
+        if ($out)
+            $content = $args['glue'] . $content;
+        else
+            $ctx->stash('__out', true);
     }
     if ( 0 === count($keys) )

branches/release-35/php/lib/block.mtparentcategories.php

@@ -21 +21 @@
 
 function smarty_block_mtparentcategories($args, $content, &$ctx, &$repeat) {
-    $localvars = array('_categories', 'category', '_categories_counter','glue');
+    $localvars = array('_categories', 'category', '_categories_counter','glue', '__out');
     if (!isset($content)) {
         $ctx->localize($localvars);
@@ -39 +39 @@
         $ctx->stash('_categories', $parents);
         $ctx->stash('glue', $glue);
+        $ctx->stash('__out', false);
         $counter = 0;
     } else {
@@ -44 +45 @@
         $counter = $ctx->stash('_categories_counter');
         $glue = $ctx->stash('glue');
+        $out = $ctx->stash('__out');
     }
 
@@ -50 +52 @@
         $ctx->stash('_categories_counter', $counter + 1);
         $repeat = true;
+        if (!empty($glue) && !empty($content)) {
+            if ($out)
+                $content = $glue . $content;
+            else
+                $ctx->stash('__out', true);
+        }
     } else {
+        if (!empty($glue) && $out && !empty($content))
+            $content = $glue . $content;
         $repeat = false;
         $glue = '';
         $ctx->restore($localvars);
     }
-    return $content.$glue;
+    return $content;
 }
 ?>

branches/release-35/php/lib/block.mttags.php

@@ -7 +7 @@
 
 function smarty_block_mttags($args, $content, &$ctx, &$repeat) {
-    $localvars = array('_tags', 'Tag', '_tags_counter', 'tag_min_count', 'tag_max_count', 'all_tag_count', 'include_blogs', 'exclude_blogs', 'blog_ids');
+  $localvars = array('_tags', 'Tag', '_tags_counter', 'tag_min_count', 'tag_max_count', 'all_tag_count', 'include_blogs', 'exclude_blogs', 'blog_ids', '__out');
     if (!isset($content)) {
         $ctx->localize($localvars);
@@ -54 +54 @@
         $ctx->stash('all_tag_count', $all_count);
         $ctx->stash('_tags', $tags);
+        $ctx->stash('__out', false);
         $counter = 0;
     } else {
         $tags = $ctx->stash('_tags');
         $counter = $ctx->stash('_tags_counter');
+        $out = $ctx->stash('__out');
     }
 
@@ -65 +67 @@
         $ctx->stash('_tags_counter', $counter + 1);
         $repeat = true;
-        if (($counter > 0) && isset($args['glue'])) {
-            $content = $content . $args['glue'];
+        if (isset($args['glue'])) {
+            if ($out && !empty($content))
+                $content = $args['glue'] . $content;
+            if (!$out && !empty($content))
+              $ctx->stash('__out', true);
         }
     } else {
+        if (isset($args['glue'])) {
+            if ($out && !empty($content))
+                $content = $args['glue'] . $content;
+        }
         $ctx->restore($localvars);
         $repeat = false;