Changeset 1889

Timestamp:

04/14/08 18:28:41 (22 months ago)

Author:

bsmith

Message:

bugzid:74303 - Review Design of Threaded Comments

Location:

branches/release-34

Files:

• default_templates/comment_preview.mtml (modified) (1 diff)
• default_templates/comments.mtml (modified) (2 diffs)
• default_templates/javascript.mtml (modified) (1 diff)
• mt-static/themes-base/blog.css (modified) (2 diffs)

branches/release-34/default_templates/comment_preview.mtml

@@ -32 +32 @@
                                         <div class="asset-meta">
                                             <span class="byline">
-                                                <__trans phrase="By"> <span class="vcard author"><$MTCommentAuthorLink default_name="Anonymous" show_email="0"$></span><MTIfNonEmpty tag="CommentAuthorIdentity"><$MTCommentAuthorIdentity$></MTIfNonEmpty>
-                                                <MTCommentParent>
-                                                <__trans phrase="replied to"> <a href="#comment-<$MTCommentID$>"><$MTCommentAuthor$></a>
-                                                </MTCommentParent>
-                                                <__trans phrase="on"> <a href="#comment-<$MTCommentID$>"><abbr class="published" title="<$MTCommentDate format_name="iso8601"$>"><$MTCommentDate$></abbr></a>
+                                                <mt:IfCommentParent>
+                                                    <__trans phrase="[_1] replied to <a href="[_2]">comment from [_3]</a>" params="<MTIfNonEmpty tag="CommentAuthorIdentity"><$MTCommentAuthorIdentity$></MTIfNonEmpty> <span class="vcard author"><$MTCommentAuthorLink default_name="Anonymous" show_email="0"$></span>%%<mt:CommentParent>#comment-<$MTCommentID$></mt:CommentParent>%%<mt:CommentParent><$MTCommentAuthor$></mt:CommentParent>">
+                                                <mt:else>
+                                                    <MTIfNonEmpty tag="CommentAuthorIdentity"><$MTCommentAuthorIdentity$></MTIfNonEmpty> <span class="vcard author"><$MTCommentAuthorLink default_name="Anonymous" show_email="0"$></span>
+                                                </mt:IfCommentParent>
+                                                | <a href="#comment-<$MTCommentID$>"><abbr class="published" title="<$MTCommentDate format_name="iso8601"$>"><$MTCommentDate$></abbr></a>
                                                 <MTIfCommentsAccepted> | <$MTCommentReplyLink$></MTIfCommentsAccepted>
                                             </span>

branches/release-34/default_templates/comments.mtml

@@ -15 +15 @@
                     <div class="asset-meta">
                         <span class="byline">
-                            <__trans phrase="By"> <span class="vcard author"><$MTCommentAuthorLink default_name="Anonymous" show_email="0"$></span><MTIfNonEmpty tag="CommentAuthorIdentity"><$MTCommentAuthorIdentity$></MTIfNonEmpty>
-                            <MTCommentParent>
-                            <__trans phrase="replied to"> <a href="#comment-<$MTCommentID$>"><$MTCommentAuthor$></a>
-                            </MTCommentParent>
-                            <__trans phrase="on"> <a href="#comment-<$MTCommentID$>"><abbr class="published" title="<$MTCommentDate format_name="iso8601"$>"><$MTCommentDate$></abbr></a>
+                            <mt:IfCommentParent>
+                                <__trans phrase="[_1] replied to <a href="[_2]">comment from [_3]</a>" params="<MTIfNonEmpty tag="CommentAuthorIdentity"><$MTCommentAuthorIdentity$></MTIfNonEmpty> <span class="vcard author"><$MTCommentAuthorLink default_name="Anonymous" show_email="0"$></span>%%<mt:CommentParent>#comment-<$MTCommentID$></mt:CommentParent>%%<mt:CommentParent><$MTCommentAuthor$></mt:CommentParent>">
+                            <mt:else>
+                                <MTIfNonEmpty tag="CommentAuthorIdentity"><$MTCommentAuthorIdentity$></MTIfNonEmpty> <span class="vcard author"><$MTCommentAuthorLink default_name="Anonymous" show_email="0"$></span>
+                            </mt:IfCommentParent>
+                            | <a href="#comment-<$MTCommentID$>"><abbr class="published" title="<$MTCommentDate format_name="iso8601"$>"><$MTCommentDate$></abbr></a>
                             <MTIfCommentsAccepted> | <$MTCommentReplyLink$></MTIfCommentsAccepted>
                         </span>
@@ -73 +74 @@
                     </div>
                     <div id="comment-form-remember-me">
-                        <label for="comment-bake-cookie"><input type="checkbox" id="comment-bake-cookie" name="bakecookie" onclick="if (!this.checked) forgetMe(document.comments_form)" value="1" />
-                            <__trans phrase="Remember personal info?"></label>
+                        <input type="checkbox" id="comment-bake-cookie" name="bakecookie" onclick="if (!this.checked) forgetMe(document.comments_form)" value="1" />
+                        <label for="comment-bake-cookie"><__trans phrase="Remember personal info?"></label>
                     </div>
                     <div id="comment-form-reply">
-                        <label for="comment-reply" id="comment-reply-label"><input type="checkbox" id="comment-reply" name="comment_reply" value="" onclick="setCommentParentID();" />
-                            <__trans phrase="Replying to"></label>
+                        <input type="checkbox" id="comment-reply" name="comment_reply" value="" onclick="setCommentParentID();" />
+                        <label for="comment-reply" id="comment-reply-label"></label>
                     </div>
                 </div>

branches/release-34/default_templates/javascript.mtml

@@ -175 +175 @@
     
     var checkbox = document.getElementById('comment-reply');
-
-    // Clear the current label but NOT our checkbox!
     var label = document.getElementById('comment-reply-label');
-    for(var i = 1; i < label.childNodes.length; i++) {
-        label.removeChild(label.childNodes[i]);
-    }
-    
+    var text = document.getElementById('comment-text');
+
     // Populate label with new values
-    var reply_text = document.createTextNode(' <__trans phrase="Replying to"> ');
-    label.appendChild(reply_text);
-
-    var anchor = document.createElement('a');
-    anchor.setAttribute('href', '#comment-' + parent_id);
-    anchor.innerHTML = author;
-    label.appendChild(anchor);
-    
+    var reply_text = '<__trans phrase="Replying to <a href="#comment-[_1]">comment from [_2]</a>" params="'+ parent_id +'%%'+ author +'">';
+    label.innerHTML = reply_text;
+
     checkbox.value = parent_id; 
-    checkbox.setAttribute('checked', true);
-    checkbox.focus();
-    
+    checkbox.checked = true;
+    text.focus();
+
     setCommentParentID();
 }

branches/release-34/mt-static/themes-base/blog.css

@@ -300 +300 @@
 #comment-form-url,
 #comment-form-remember-me,
+#comment-form-reply,
 #comments-open-text,
 .trackbacks-header,
@@ -309 +310 @@
 .search-results-header {
     margin-bottom: .75em;
+}
+
+#comment-form-remember-me label,
+#comment-form-reply label {
+    display: inline;
 }