Changeset 1823 for branches/release-34/lib/MT/CMS/TrackBack.pm

Timestamp:

04/09/08 10:05:12 (20 months ago)

Author:

takayama

Message:

Fixed BugId:67959
* Added check for result of object loading

Files:

• branches/release-34/lib/MT/CMS/TrackBack.pm (modified) (6 diffs)

branches/release-34/lib/MT/CMS/TrackBack.pm

@@ -186 +186 @@
                 my $pkg   = $app->model('entry');
                 my $entry = $pkg->load($val);
-                $param{filter_phrase} = $app->translate(
-"TrackBacks where <strong>[_1]</strong> is &quot;[_2]&quot;.",
-                    $entry->class_label,
-                    encode_html( $entry->title )
-                );
+                if ($entry) {
+                    $param{filter_phrase} = $app->translate(
+    "TrackBacks where <strong>[_1]</strong> is &quot;[_2]&quot;.",
+                        $entry->class_label,
+                        encode_html( $entry->title )
+                    );
+                }
             }
             elsif ( $filter_col eq 'category_id' ) {
                 my $pkg = $app->model('category');
                 my $cat = $pkg->load($val);
-                $param{filter_phrase} = $app->translate(
-"TrackBacks where <strong>[_1]</strong> is &quot;[_2]&quot;.",
-                    $cat->class_label,
-                    encode_html( $cat->label )
-                );
+                if ($cat) {
+                    $param{filter_phrase} = $app->translate(
+    "TrackBacks where <strong>[_1]</strong> is &quot;[_2]&quot;.",
+                        $cat->class_label,
+                        encode_html( $cat->label )
+                    );
+                }
             }
             $param{filter_special} = 1;
@@ -343 +347 @@
             require MT::Entry;
             my $entry = MT::Entry->load( $tb->entry_id );
-            return ( $entry->author_id == $app->user->id
+            return ( !$entry
+                  || $entry->author_id == $app->user->id
                   || $perms->can_manage_feedback
                   || $perms->can_edit_all_posts );
@@ -368 +373 @@
       && ( $perms->can_edit_all_posts
         || $perms->can_manage_feedback );
-    my $p      = MT::TBPing->load($id);
+    my $p      = MT::TBPing->load($id)
+        or return 0;
     my $tbitem = $p->parent;
     if ( $tbitem->isa('MT::Entry') ) {
@@ -404 +410 @@
     my $perms = $app->permissions;
     require MT::Trackback;
-    my $tb = MT::Trackback->load( $obj->tb_id );
+    my $tb = MT::Trackback->load( $obj->tb_id )
+        or return 0;
     if ( my $entry = $tb->entry ) {
         if ( !$perms || $perms->blog_id != $entry->blog_id ) {
@@ -439 +446 @@
         return 1 unless $perms->can_publish_post || $perms->can_edit_categories;
         require MT::Trackback;
-        my $tb = MT::Trackback->load( $obj->tb_id );
+        my $tb = MT::Trackback->load( $obj->tb_id )
+            or return 0;
         if ($tb) {
             if ( $tb->entry_id ) {
@@ -445 +453 @@
                 my $entry = MT::Entry->load( $tb->entry_id );
                 return 1
-                  unless ( $entry->author_id == $app->user->id )
+                  if ( !$entry || $entry->author_id != $app->user->id )
                   && $perms->can_publish_post;
             }