Changeset 1823 for branches/release-34/lib/MT/CMS/Comment.pm

Timestamp:

04/09/08 10:05:12 (20 months ago)

Author:

takayama

Message:

Fixed BugId:67959
* Added check for result of object loading

Files:

• branches/release-34/lib/MT/CMS/Comment.pm (modified) (9 diffs)

branches/release-34/lib/MT/CMS/Comment.pm

@@ -1058 +1058 @@
     foreach my $id (@ids) {
         next unless $id;
-        my $obj = $class->load($id);
+        my $obj = $class->load($id)
+            or next;
         unless ($perm_checked) {
             if ( $obj->isa('MT::TBPing') && $obj->parent->isa('MT::Entry') ) {
@@ -1247 +1248 @@
     my $blog = $parent->blog
             || $app->model('blog')->load($q->param('blog_id'));
+    return $app->error($app->translate('Can\'t load blog #[_1].', $q->param('blog_id'))) unless $blog;
 
     require MT::Sanitize;
@@ -1318 +1320 @@
     my $blog = $parent->blog
             || $app->model('blog')->load($app->param('blog_id'));
+    return $app->error($app->translate('Can\'t load blog #[_1].', $app->param('blog_id'))) unless $blog;
 
     require MT::Sanitize;
@@ -1372 +1375 @@
         || $perms->can_manage_feedback );
 
-    my $c = MT::Comment->load($id);
+    my $c = MT::Comment->load($id)
+        or return 0;
     if ( $perms && $perms->can_create_post && $perms->can_publish_post ) {
         return $c->entry->author_id == $app->user->id;
@@ -1401 +1405 @@
     my $perms = $app->permissions;
     require MT::Entry;
-    my $entry = MT::Entry->load( $obj->entry_id );
+    my $entry = MT::Entry->load( $obj->entry_id )
+        or return 0;
     if ( !$perms || $perms->blog_id != $entry->blog_id ) {
         $perms ||= $author->permissions( $entry->blog_id );
@@ -1609 +1614 @@
     require MT::Entry;
     foreach my $id (@obj_ids) {
-        my $obj = $class->load($id);
+        my $obj = $class->load($id)
+            or next;
         my $old_visible = $obj->visible || 0;
         if ( $old_visible != $new_visible ) {
@@ -1692 +1698 @@
     for my $id (@$comments) {
         my $cmt = MT::Comment->load($id);
-        if ( $cmt->commenter_id ) {
+        if ( $cmt && $cmt->commenter_id ) {
             $commenters{ $cmt->commenter_id . ':' . $cmt->blog_id } =
               [ $cmt->commenter_id, $cmt->blog_id ];
@@ -1711 +1717 @@
     my $entry         = $app->model('entry')->load( $parent->entry_id );
 
-    unless ( $parent->is_published ) {
+    if ( !$parent || $parent->is_published ) {
         $app->error(
             $app->translate("You can't reply to unpublished comment.") );
@@ -1721 +1727 @@
         return ( undef, $parent, $entry );
     }
-
-    my $blog = $app->model('blog')->load( $entry->blog_id );
 
     my $nick = $app->user->nickname || $app->translate('Registered User');