Changeset 1731

Timestamp:

04/02/08 23:27:20 (23 months ago)

Author:

bchoate

Message:

Adding embedded column to MT::ObjectAsset. BugId:71500. Thanks, Tim!

Location:

branches/release-33

Files:

• build/mt-dists/default.mk (modified) (1 diff)
• lib/MT/Entry.pm (modified) (4 diffs)
• lib/MT/ObjectAsset.pm (modified) (1 diff)
• lib/MT/Upgrade.pm (modified) (8 diffs)

branches/release-33/build/mt-dists/default.mk

@@ -2 +2 @@
 
 PRODUCT_VERSION = 4.15
-SCHEMA_VERSION = 4.0051
+SCHEMA_VERSION = 4.0052
 API_VERSION = 4.15
 

branches/release-33/lib/MT/Entry.pm

@@ -622 +622 @@
         object_id => $entry->id,
         blog_id => $entry->blog_id,
-        object_ds => $entry->datasource
+        object_ds => $entry->datasource,
+        embedded => 1,
     });
     my %assets = map { $_->asset_id => $_->id } @assets;
@@ -629 +630 @@
         my $innards = $2;
 
-        # is asset exists?
-        my $asset = MT->model('asset')->load({ id => $id }) or next;
-
         # reference to an existing asset...
         if (exists $assets{$id}) {
             $assets{$id} = 0;
         } else {
+            # is asset exists?
+            my $asset = MT->model('asset')->load({ id => $id }) or next;
+
             my $map = new MT::ObjectAsset;
             $map->blog_id($entry->blog_id);
@@ -641 +642 @@
             $map->object_ds($entry->datasource);
             $map->object_id($entry->id);
+            $map->embedded(1);
             $map->save;
             $assets{$id} = 0;
@@ -646 +648 @@
     }
     if (my @old_maps = grep { $assets{$_->asset_id} } @assets) {
-        my @old_ids = map { $_->id } @old_maps;
-        MT::ObjectAsset->remove( { id => \@old_ids });
+        my @old_ids = map { $_->id } grep { $_->embedded } @old_maps;
+        MT::ObjectAsset->remove( { id => \@old_ids })
+            if @old_ids;
     }
     return 1;

branches/release-33/lib/MT/ObjectAsset.pm

@@ -18 +18 @@
         object_ds => 'string(50) not null',
         asset_id => 'integer not null',
+        embedded => 'boolean',
     },
     indexes => {
-        blog_id => 1,
-        object_id => 1,
+        blog_obj => {
+            columns => ['blog_id', 'object_ds', 'object_id'],
+        },
         asset_id => 1,
-        object_ds => 1,
+    },
+    defaults => {
+        embedded => 0,
     },
     child_of => 'MT::Blog',

branches/release-33/lib/MT/Upgrade.pm

@@ -548 +548 @@
             priority => 5.1,
         },
+        'core_migrate_commenter_auth' => {
+            code => \&migrate_commenter_auth,
+            version_limit => 3.3101,
+            priority => 3.1,
+        },
         'core_deprecate_bitmask_permissions' => {
             code => \&deprecate_bitmask_permissions,
@@ -557 +562 @@
             version_limit => 4.0002,
             priority => 3.3,
-        },
-        'core_migrate_commenter_auth' => {
-            code => \&migrate_commenter_auth,
-            version_limit => 3.3101,
-            priority => 3.1,
         },
         'core_populate_authored_on' => {
@@ -689 +689 @@
                 type => 'author',
                 label => 'Adding new feature widget to dashboard...',
+                condition => sub {
+                    my ($user) = @_;
+                    $user->type == MT::Author::AUTHOR(); # AUTHOR records only
+                },
                 code => sub {
                     my ($user) = @_;
@@ -703 +707 @@
                     }
                     $user->widgets($widget_store);
-                    $user->save;
                 },
             },
@@ -775 +778 @@
                     }
                     $blog->page_layout($layout);
-                    $blog->save;
                 },
             },
@@ -792 +794 @@
                     my $basename = MT::Util::make_unique_author_basename($author);
                     $author->basename($basename);
-                    $author->save;
                 },
             },
@@ -806 +807 @@
             updater       => {
                 type      => 'entry',
-                label     => 'Assigning entry comment and trackback count...',
+                label     => 'Assigning entry comment and TrackBack counts...',
                 condition => sub {
                     require MT::Comment;
@@ -834 +835 @@
                 # it doesn't have the unnecessary save.
                 code => sub { 1; },
+            },
+        },
+        'core_assign_object_embedded' => {
+            version_limit => 4.0052,
+            priority => 3.2,
+            updater => {
+                type => 'objectasset',
+                label => 'Assigning embedded flag to asset placements...',
+                code => sub {
+                    $_[0]->embedded(1);
+                },
+                sql => 'update mt_objectasset set objectasset_embedded=1',
             },
         },