Changeset 1427 for branches/release-30/lib/MT/Template.pm

Timestamp:

02/28/08 22:31:24 (21 months ago)

Author:

mpaschal

Message:

Add MT::Util::weaken() that lets us weaken references when available from a properly compiled Scalar::Util
Use weaken() to prevent some circular references from leaking some objects
(apply patches by Hirotaka Ogawa and Brad Choate--thanks!)
BugzID: 66845

Files:

• branches/release-30/lib/MT/Template.pm (modified) (6 diffs)

branches/release-30/lib/MT/Template.pm

@@ -9 +9 @@
 use strict;
 use base qw( MT::Object );
+use MT::Util qw( weaken );
 
 use constant NODE => 'MT::Template::Node';
@@ -143 +144 @@
     require MT::Template::Context;
     my $ctx = $tmpl->{context} ||= MT::Template::Context->new;
-    $ctx->stash('template', $tmpl);
+    weaken($ctx->{__stash}{'template'} = $tmpl);
     return $ctx;
 }
@@ -616 +617 @@
     my $tmpl = shift;
     my ($tag, $attr) = @_;
-    return bless [ $tag, $attr, undef, undef, undef, undef, $tmpl ], NODE;
+    my $node = bless [ $tag, $attr, undef, undef, undef, undef, $tmpl ], NODE;
+    weaken($node->[6]);
+    return $node;
 }
 
@@ -622 +625 @@
     my $tmpl = shift;
     my ($text) = @_;
-    return bless [ 'TEXT', $text, undef, undef, undef, undef, $tmpl ], NODE;
+    my $node = bless [ 'TEXT', $text, undef, undef, undef, undef, $tmpl ], NODE;
+    weaken($node->[6]);
+    return $node;
 }
 
@@ -740 +745 @@
 
 use strict;
+use MT::Util qw( weaken );
 
 sub setAttribute {
@@ -823 +829 @@
     my $node = shift;
     $node->[5] = shift if @_;
+    weaken($node->[5]);
     $node->[5];
 }