Changeset 372

Timestamp:

08/24/06 22:54:07 (2 years ago)

Author:

marksmith

Message:

* make this do readable vs writeable and throw errors

Files:

• branches/server-newrepl/mogilefsd (modified) (3 diffs)

branches/server-newrepl/mogilefsd

@@ -239 +239 @@
-    my %opts = ( @_ );
-
+    # validate we're getting called with known parameters
+    my %valid_keys = map { $_ => 1 } qw( random min_free_space weight_by_free max_disk_age not_on_hosts must_be_writeable must_be_readable ); 
+    warn "invalid key $_ in call to find_deviceid\n"
+        foreach grep { ! $valid_keys{$_} } keys %opts;
+
-    # copy down global minimum free space if not specified
-    $opts{min_free_space} ||= MogileFS->config("min_free_space");
@@ -245 +250 @@
-        $opts{max_disk_age} = time() - ($opts{max_disk_age} * 60);
-    }
- 
+
-
-    # setup for iterating over devices
@@ -268 +273 @@
-        next if $opts{min_free_space} && $dev->{mb_total} &&
-                $dev->{mb_free} < $opts{min_free_space};
-aliv
+writeabl
-            (MogileFS->observed_state("host", $dev->{hostid}) ne "reachable" ||
-             MogileFS->observed_state("device", $dev->{devid}) ne "writeable");
+        next if $opts{must_be_readable} &&
+            (MogileFS->observed_state("host", $dev->{hostid}) ne "reachable" ||
+             MogileFS->observed_state("device", $dev->{devid}) ne "readable");
-
-        # we get here, this is a suitable device