Changeset 1340

Show
Ignore:
Timestamp:
11/05/09 06:41:46 (3 weeks ago)
Author:
robbat2
Message:

Ok, the solaris leak ended being elsewhere, but we still want to keep the max_handles code, so clean things up a bit before apply the real fix. Thanks to <victoriggy@…>.

Files:
1 modified

Legend:

Unmodified
Added
Removed

  • trunk/server/lib/MogileFS/Store.pm

    r1339 r1340  
    266266                $self->{max_handles} > 0 &&  
    267267                $self->{handles_given} > $self->{max_handles}) { 
    268                         # TODO: Not sure about this disconnect. We probably want existing 
    269                         # users of the connection to continue to do so. 
    270                         $self->{dbh}->disconnect(); 
     268            # Do not destory existing copies of this handle. 
     269            $self->{dbh}{InactiveDestroy} = 0; 
     270            $self->{dbh}->disconnect(); 
    271271            $self->{dbh} = undef; 
    272272            $self->{handles_given} = 0; 
    … …  
    278278            PrintError => 0, 
    279279            AutoCommit => 1, 
    280             InactiveDestroy => 1, 
    281280            # FUTURE: will default to on (have to validate all callers first): 
    282281            RaiseError => ($self->{raise_errors} || 0),