Changeset 1303

Timestamp:

10/14/09 06:43:10 (6 weeks ago)

Author:

dormando

Message:

Default to 64-bit things in MySQL

We always trip people up a few years down the line when they have more than 4b
file revisions, or try to store a really big file. Lets just flip the defaults
to make it simpler for people down the road...

Location:

trunk/server/lib/MogileFS

Files:

• Store.pm (modified) (1 diff)
• Store/MySQL.pm (modified) (1 diff)

trunk/server/lib/MogileFS/Store.pm

@@ -482 +482 @@
     UNIQUE dkey  (dmid, dkey),
 
-    length        INT UNSIGNED,        # 4GB limit
+    length        BIGINT UNSIGNED,   # big limit
 
     classid       TINYINT UNSIGNED NOT NULL,

trunk/server/lib/MogileFS/Store/MySQL.pm

@@ -147 +147 @@
     if ($create && $create =~ /\bbigint\b/i) {
         return $self->{_fid_type} = "BIGINT";
-    }
-
-    # else, use 32-bit ints for the fid type
-    return $self->{_fid_type} = "INT";
+    } else {
+        # Old installs might not have raised the fid type size yet.
+        return $self->{_fid_type} = "INT";
+    }
+
+    # Used to default to 32bit ints, but this always bites people
+    # a few years down the road. So default to 64bit.
+    return $self->{_fid_type} = "BIGINT";
 }