Changeset 1183

Show
Ignore:
Timestamp:
06/05/08 22:36:42 (6 months ago)
Author:
robbat2
Message:

Fix postgres lock release being overzealous.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/server/CHANGES

    r1166 r1183  
     1        * Postgres locking routines did not include the hostname for the lock 
     2          release. 
     3 
    14        * RFC 2518 says we "should" use a trailing slash when calling 
    25          MKCOL. Some servers (nginx) appears to require it. (Spotted by 

  • trunk/server/lib/MogileFS/Store/Postgres.pm

    r1125 r1183  
    696696    debug("$$ Unlocking $lockname ($lockid)\n") if $Mgd::DEBUG >= 5; 
    697697    #my $rv = $self->dbh->selectrow_array("SELECT pg_advisory_unlock(?)", undef, $lockid); 
    698     my $rv = $self->dbh->do('DELETE FROM lock WHERE lockid=? AND pid=?', undef, $lockid, $$); 
     698    my $rv = $self->dbh->do('DELETE FROM lock WHERE lockid=? AND pid=? AND hostname=?', undef, $lockid, $$, hostname); 
    699699    debug("Double-release of lock $lockname!") if $self->{lock_depth} != 0 and $rv == 0 and $Mgd::DEBUG >= 2; 
    700700    $self->condthrow;