Changeset 1137

Timestamp:

01/24/08 02:08:33 (10 months ago)

Author:

hachi

Message:

Add --chmod-mountpoints option to mogautomount, which drops read/write access on the underlying filesystem directory where a mogile filesystem before it's mounted.

Files:

• trunk/server/CHANGES (modified) (1 diff)
• trunk/server/mogautomount (modified) (3 diffs)

trunk/server/CHANGES

@@ -1 @@
-
+
+
+
+
+
-
-        * Use correct per-Store port, defaulting to UNIX sockets on localhost.

trunk/server/mogautomount

@@ -7 +7 @@
-$0 = $_ = $0;
-
-
+, $chmod_mountpoints
-usage(0) unless GetOptions(
-                           'help' => \$help,
-                           'verbose' => \$verbose,
+                           'chmod-mountpoints' => \$chmod_mountpoints,
-                           );
-usage(0) if @ARGV;
@@ -49 +50 @@
-    unless (-d $mnt) { mkdir $mnt or die "Failed to mkdir $mnt: $!"; }
-    next if $mounted{$dev};
+
+    if ($chmod_mountpoints and ((stat($mnt))[2] & 0777) != 0) {
+        warn "Mountpoint on parent filesystem is writable, fixing.\n" if $verbose;
+        chmod 0, $mnt
+            or die "Unable to set mogile device mountpoint '$mnt' mode to 0 (no access)";
+    }
-
-    if (system("mount", '-o', 'noatime', $dev, $mnt)) {
@@ -94 +101 @@
-be verbose
-
+=item --chmod-mountpoints
+
+If a mogile device isn't mounted yet, check to make sure the underlying filesystem has the directory set
+to be not readable or writable at all (chmod 0). This could help prevent mogstored from accidentally writing
+to the underlying filesystem.
+
-=back
-