Changeset 818

Timestamp:

07/20/09 09:13:31 (4 months ago)

Author:

dormando

Message:

Add append/prepend support.

Location:

trunk/api/perl

Files:

• lib/Cache/Memcached.pm (modified) (4 diffs)
• t/02_keys.t (modified) (2 diffs)

trunk/api/perl/lib/Cache/Memcached.pm

@@ -441 +441 @@
 }
 
+sub append {
+    _set("append", @_);
+}
+
+sub prepend {
+    _set("prepend", @_);
+}
+
 sub _set {
     my $cmdname = shift;
@@ -452 +460 @@
     use bytes; # return bytes from length()
 
+    my $app_or_prep = $cmdname eq 'append' || $cmdname eq 'prepend' ? 1 : 0;
     $self->{'stats'}->{$cmdname}++;
     my $flags = 0;
@@ -457 +466 @@
 
     if (ref $val) {
+        die "append or prepend cannot take a reference" if $app_or_prep;
         local $Carp::CarpLevel = 2;
         $val = Storable::nfreeze($val);
@@ -466 +476 @@
 
     if ($self->{'compress_threshold'} && $HAVE_ZLIB && $self->{'compress_enable'} &&
-        $len >= $self->{'compress_threshold'}) {
+        $len >= $self->{'compress_threshold'} && !$app_or_prep) {
 
         my $c_val = Compress::Zlib::memGzip($val);

trunk/api/perl/t/02_keys.t

@@ -10 +10 @@
                                   Timeout  => 3);
 if ($msock) {
-    plan tests => 13;
+    plan tests => 20;
 } else {
     plan skip_all => "No memcached instance running at $testaddr\n";
@@ -37 +37 @@
 ok(! $memd->get("key1"), "get key1 properly failed");
 
+ok(! $memd->append("key-noexist", "bogus"), "append key-noexist properly failed");
+ok(! $memd->prepend("key-noexist", "bogus"), "prepend key-noexist properly failed");
+
+ok($memd->set("key3", "base"), "set key3 to base");
+ok($memd->append("key3", "-end"), "appended -end to key3");
+ok($memd->get("key3", "base-end"), "key3 is base-end");
+ok($memd->prepend("key3", "start-"), "prepended start- to key3");
+ok($memd->get("key3", "start-base-end"), "key3 is base-end");
 
 # also test creating the object with a list rather than a hash-ref