Changeset 784

Timestamp:

06/23/08 04:05:08 (2 months ago)

Author:

dormando

Message:

Fix freesuffix corruption.

When attempting to grow the freesuffix storage, the realloc is sized
to the number of bytes in freesuffixtotal instead of a number of
pointers of that size.

That is, the original malloc is for

sizeof(char *) * freesuffixtotal

but the realloc for growth was

freesuffixtotal * 2

On a 32-bit machine, this would have the effect of freeing half of
the freelist when an attempt was made to grow it.

The realloc is now consistent with the initial malloc.

Files:

• trunk/server/memcached.c (modified) (1 diff)

trunk/server/memcached.c

@@ -594 +594 @@
-    } else {
-        /* try to enlarge free connections array */
-
+
+
-        if (new_freesuffix) {
-            freesuffixtotal *= 2;