Changeset 754 for branches/binary/server/memcached.c

Timestamp:

03/18/08 17:21:05 (2 years ago)

Author:

dsallings

Message:

Ensure all connection states are expressed as enums.

Function declarations should have parameter names.

Files:

• branches/binary/server/memcached.c (modified) (5 diffs)

branches/binary/server/memcached.c

@@ -70 +70 @@
 static int try_read_network(conn *c);
 static int try_read_udp(conn *c);
-static void conn_set_state(conn *, int);
+static void conn_set_state(conn *c, enum conn_states state);
 
 /* stats */
@@ -314 +314 @@
 }
 
-conn *conn_new(const int sfd, const int init_state, const int event_flags,
+conn *conn_new(const int sfd, enum conn_states init_state,
+                const int event_flags,
                 const int read_buffer_size, enum protocol prot,
                 struct event_base *base) {
@@ -513 +514 @@
 }
 
-static int get_init_state(conn *c) {
+static enum conn_states get_init_state(conn *c) {
     int rv=0;
     assert(c != NULL);
@@ -601 +602 @@
  * happen here.
  */
-static void conn_set_state(conn *c, int state) {
+static void conn_set_state(conn *c, enum conn_states state) {
     assert(c != NULL);
 
@@ -2726 +2727 @@
     bool stop = false;
     int sfd, flags = 1;
-    int init_state; /* initial state for a new connection */
+    enum conn_states init_state; /* initial state for a new connection */
     socklen_t addrlen;
     struct sockaddr_storage addr;