Changeset 645

Timestamp:

11/19/07 00:15:18 (1 year ago)

Author:

dormando

Message:

Reduce mutex contention in get command for multiple keys. (Tomash Brechko)

Files:

• trunk/server/memcached.c (modified) (5 diffs)

trunk/server/memcached.c

@@ -1103 +1103 @@
-    token_t *key_token = &tokens[KEY_TOKEN];
-    char suffix[255];
+    int stats_get_cmds   = 0;
+    int stats_get_hits   = 0;
+    int stats_get_misses = 0;
-    assert(c != NULL);
-
@@ -1125 +1128 @@
-
-            if(nkey > KEY_MAX_LENGTH) {
+                STATS_LOCK();
+                stats.get_cmds   += stats_get_cmds;
+                stats.get_hits   += stats_get_hits;
+                stats.get_misses += stats_get_misses;
+                STATS_UNLOCK();
-                out_string(c, "CLIENT_ERROR bad command line format");
-                return;
-            }
-
-
-
-
+
-            it = item_get(key, nkey);
-            if (settings.detail_enabled) {
@@ -1180 +1186 @@
-
-                /* item_get() has incremented it->refcount for us */
-
-
-
+
-                item_update(it);
-                *(c->ilist + i) = it;
@@ -1188 +1192 @@
-
-            } else {
-
-
-
+
-            }
-
@@ -1226 +1228 @@
-        c->msgcurr = 0;
-    }
+
+    STATS_LOCK();
+    stats.get_cmds   += stats_get_cmds;
+    stats.get_hits   += stats_get_hits;
+    stats.get_misses += stats_get_misses;
+    STATS_UNLOCK();
+
-    return;
-}