Changeset 576

Timestamp:

07/03/07 18:11:47 (2 years ago)

Author:

bradfitz

Message:

update the stats method (from Ronald J Kimball <rkimball+memcached@pangeamedia.com>)

Files:

• trunk/api/perl/ChangeLog (modified) (1 diff)
• trunk/api/perl/lib/Cache/Memcached.pm (modified) (3 diffs)

trunk/api/perl/ChangeLog

@@ +1 @@
+        * update the stats method, including tests for it
+          (Ronald J Kimball <rkimball+memcached@pangeamedia.com>)
+
-        * arguments to 'new' constructor can be %hash or $hashref now
-          (previously was only $hashref)

trunk/api/perl/lib/Cache/Memcached.pm

@@ -831 +831 @@
-    }
-
+    my %misc_keys = map { $_ => 1 }
+      qw/ bytes bytes_read bytes_written
+          cmd_get cmd_set connection_structures curr_items
+          get_hits get_misses
+          total_connections total_items
+        /;
+
-    # Now handle the other types, passing each type to each host server.
-    my @hosts = @{$self->{'buckets'}};
-    my %malloc_keys = ( );
-  HOST: foreach my $host (@hosts) {
-        my $sock = $self->sock_to_host($host);
@@ -863 +869 @@
-                        $stats_hr->{'hosts'}{$host}{$typename}{$key} = $value;
-                    }
-
+
+
+
+
-                }
-            } else {
@@ -872 +881 @@
-                $stats_hr->{'hosts'}{$host}{$typename} .= "$lines";
-            }
-        }
-    }
-
-    # Now get the sum total of applicable values.  First the misc values.
-    foreach my $stat (qw(
-        bytes bytes_read bytes_written
-        cmd_get cmd_set connection_structures curr_items
-        get_hits get_misses
-        total_connections total_items
-        )) {
-        $stats_hr->{'total'}{$stat} = 0;
-        foreach my $host (@hosts) {
-            $stats_hr->{'total'}{$stat} +=
-                $stats_hr->{'hosts'}{$host}{'misc'}{$stat};
-        }
-    }
-
-    # Then all the malloc values, if any.
-    foreach my $malloc_stat (keys %malloc_keys) {
-        $stats_hr->{'total'}{"malloc_$malloc_stat"} = 0;
-        foreach my $host (@hosts) {
-            $stats_hr->{'total'}{"malloc_$malloc_stat"} +=
-                $stats_hr->{'hosts'}{$host}{'malloc'}{$malloc_stat};
-        }
-    }