Changeset 438 for branches/performance

Timestamp:

11/20/06 22:05:31 (3 years ago)

Author:

sgrimm

Message:

Fix for flush_all 1-second window bug. You can now do a "set" immediately
after a "flush_all" without the newly set data getting expired. (Ported
from trunk.)

Location:

branches/performance/server

Files:

• items.c (modified) (1 diff)
• memcached.c (modified) (3 diffs)
• memcached.h (modified) (1 diff)
• t/flush-all.t (modified) (2 diffs)

branches/performance/server/items.c

@@ -330 +330 @@
     return buf;
 }
+
+/* expires items that are more recent than the oldest_live setting. */
+void item_flush_expired() {
+    int i;
+    item *iter, *next;
+    if (! settings.oldest_live)
+        return;
+    for (i = 0; i < LARGEST_ID; i++) {
+        /* The LRU is sorted in decreasing time order, and an item's timestamp
+         * is never newer than its last access time, so we only need to walk
+         * back until we hit an item older than the oldest_live time.
+         * The oldest_live checking will auto-expire the remaining items.
+         */
+        for (iter = heads[i]; iter != NULL; iter = next) {
+            if (iter->time >= settings.oldest_live) {
+                next = iter->next;
+                if ((iter->it_flags & ITEM_SLABBED) == 0) {
+                    item_unlink(iter);
+                }
+            } else {
+                /* We've hit the first old item. Continue to the next queue. */
+                break;
+            }
+        }
+    }
+}

branches/performance/server/memcached.c

@@ -97 +97 @@
     stats.curr_bytes = stats.bytes_read = stats.bytes_written = 0;
 
-    /* make the time we started always be 1 second before we really
+    /* make the time we started always be 2 seconds before we really
        did, so time(0) - time.started is never zero.  if so, things
        like 'settings.oldest_live' which act as booleans as well as
        values are now false in boolean context... */
-    stats.started = time(0) - 1;
+    stats.started = time(0) - 2;
 }
 
@@ -1338 +1338 @@
 
         if(ntokens == 2) {
-            settings.oldest_live = current_time;
+            settings.oldest_live = current_time - 1;
+            item_flush_expired();
             out_string(c, "OK");
             return;
@@ -1349 +1350 @@
         }
 
-        settings.oldest_live = realtime(exptime);
+        settings.oldest_live = realtime(exptime) - 1;
+        item_flush_expired();
         out_string(c, "OK");
         return;

branches/performance/server/memcached.h

@@ -277 +277 @@
 char *item_stats_sizes(int *bytes);
 void item_stats(char *buffer, int buflen);
+void item_flush_expired(void);
 
 /* time handling */

branches/performance/server/t/flush-all.t

@@ -2 +2 @@
 
 use strict;
-use Test::More tests => 11;
+use Test::More tests => 10;
 use FindBin qw($Bin);
 use lib "$Bin/lib";
@@ -17 +17 @@
 print $sock "flush_all\r\n";
 is(scalar <$sock>, "OK\r\n", "did flush_all");
+mem_get_is($sock, "foo", undef);
 
-mem_get_is($sock, "foo", undef);
-SKIP: {
-    skip "flush_all is still only second-granularity.  need atomic counter on flush_all.", 2 unless 0;
-
-    print $sock "set foo 0 0 3\r\nnew\r\n";
-    is(scalar <$sock>, "STORED\r\n", "stored foo = 'new'");
-    mem_get_is($sock, "foo", 'new');
-}
-
-sleep 1;
-mem_get_is($sock, "foo", undef);
+# check that flush_all doesn't blow away items that immediately get set
+print $sock "set foo 0 0 3\r\nnew\r\n";
+is(scalar <$sock>, "STORED\r\n", "stored foo = 'new'");
+mem_get_is($sock, "foo", 'new');
 
 # and the other form, specifying a flush_all time...