Changeset 863

Timestamp:

03/27/09 18:35:01 (12 months ago)

Author:

mart

Message:

Remove stream:features-in-dialback quirk hack, since we've been unable to find an implementation that actually requires it, it's not valid per spec, and it breaks interop with several popular implementations.

Patch from Alex Vandiver.

Location:

trunk/DJabberd

Files:

• CHANGES (modified) (1 diff)
• lib/DJabberd/Connection/ServerOut.pm (modified) (1 diff)

trunk/DJabberd/CHANGES

@@ +1 @@
+  - Remove the stream:features-in-dialback quirk hack, since it breaks
+    interop with a few different implementations and is incorrect
+    per spec. This may break interop with some other implementation,
+    but we've been unable to determine which one, so I'm assuming
+    that it's no longer an issue.
+    (Alex Vandiver <alexmv@bestpractical.com>)
+
   - Small tweak to comment and logging in DJabberd::Connection::ServerOut
     (Alex Vandiver <alexmv@bestpractical.com>)

trunk/DJabberd/lib/DJabberd/Connection/ServerOut.pm

@@ -85 +85 @@
     $self->log->debug("Connection $self->{id} supports dialback");
 
-    if ($ss->version->supports_features) {
-        # they can eat a dick for all we care.  they get no features.
-        # what is this weird XMPP 1.0 + old-school Dialback world anyway?
-        # maybe we're still confused.  FIXME: care.
-        my $features = "<stream:features></stream:features>";
-        $self->write($features);
-        $self->log->debug("$self->{id} sending '$features'");
-    }
-
     my $vhost       = $self->{queue}->vhost;
     my $orig_server = $vhost->name;