Changeset 152

Timestamp:

05/23/07 18:34:29 (3 years ago)

Author:

bradfitz

Message:

stop leaking tempfiles

Location:

trunk

Files:

• Changes (modified) (1 diff)
• TODO (modified) (1 diff)
• lib/Brackup/Test.pm (modified) (5 diffs)
• lib/Brackup/Util.pm (added)

trunk/Changes

@@ -3 +3 @@
     chunks (once a command exists to delete a brackup file from a target)
 
-  - stop leaking some temp files during restores
+  - stop leaking temp files
 
   - doc fixes/additions

trunk/TODO

@@ -36 +36 @@
 -- ionice stuff.  network nice stuff.
 
--- leaking 3 /tmp files after each run?
-
 -- make tests pass without 'noatime' mount option
 

trunk/lib/Brackup/Test.pm

@@ -23 +23 @@
     if ($$ == $par_pid) {
         my $rv = unlink @to_unlink;
-        temp_audit();
     }
-}
-
-my $start_temps;
-sub num_temps {
-    opendir(my $dh, "/tmp") or return 0;
-    my @items = readdir($dh);
-    return scalar @items;
-}
-sub temp_audit {
-    my $now = num_temps();
-    $start_temps ||= $now;
-    unless ($now == $start_temps) {
-        print "# temp files changed: $start_temps -> $now\n";
-    }
-}
-
-BEGIN {
-    temp_audit();
 }
 
@@ -51 +32 @@
     die if %opts;
 
-    temp_audit();
     my $initer = shift;
 
@@ -96 +76 @@
     ok(-s $meta_filename, "backup file has size");
 
-    temp_audit();
     return wantarray ? ($meta_filename, $backup) : $meta_filename;
 }
@@ -103 +82 @@
     my $backup_file = shift;
     my $restore_dir = tempdir( CLEANUP => 1 );
-    temp_audit();
     ok_dir_empty($restore_dir);
 
@@ -114 +92 @@
     ok(eval { $restore->restore; }, "did the restore")
         or die "restore failed: $@";
-    temp_audit();
     return $restore_dir;
 }