Changeset 150

Timestamp:

05/23/07 17:24:21 (3 years ago)

Author:

bradfitz

Message:

more brackup-target work, and todo/changes updates

Location:

trunk

Files:

• Changes (modified) (1 diff)
• TODO (modified) (3 diffs)
• brackup-target (modified) (1 diff)

trunk/Changes

@@ +1 @@
+  - brackup-target tool, to list/get brackup files from a target,
+    and in the future do garbage collection on no-longer-referenced
+    chunks (once a command exists to delete a brackup file from a target)
+
+  - stop leaking some temp files during restores
+
+  - doc fixes/additions
+
 1.02 (may 22, 2007)
 

trunk/TODO

@@ +1 @@
+-- only use tempfiles in a 0700 directory under /tmp/brackup-$USER/ or
+   wherever.  or option, when using encryption, to only doing
+   in-memory tempfiles, to avoid hitting disk?
+
+-- (a future version of brackup-restore will let you grab the metafile from
+   the target, but that's still a TODO item)
+
 -- <lj user=grahams>: if a file which existed when Brackup was
   "discovering files" subsequently goes away while Brackup is working
@@ -8 +15 @@
    the metafile also barf, having a trailing \r or \n?
 
+-- "brackup-target <target> gc": find/clean orphan chunks on a target
+   from metafiles
+
 -- figure out how files with intenal \r or \n in filename get written
    to metafile.  need to be escaped?
 
 -- FUSE script to mount a *.brackup file
-
--- fix up docs, move all to POD, in relevant classes.
 
 -- tool to clean digestcache, based on prefixes, looking for files that no longer
@@ -26 +34 @@
    would be pretty easy.  
 
--- find/clean orphan chunks on a target from metafiles
-
--- (a future version of brackup-restore will let you grab the metafile from
-   the target, but that's still a TODO item)
-
 -- ionice stuff.  network nice stuff.
 
--- leaking 3 /tmp files after each run
+-- leaking 3 /tmp files after each run?x
 
 -- make tests pass without 'noatime' mount option

trunk/brackup-target

@@ -112 +112 @@
 sub CMD_get_backups {
     foreach my $si ($target->backups) {
-        debug("Fetching " . $si->filename);
+        my $size = $si->size;
+        my $name = $si->filename;
+        no warnings 'uninitialized';
+        if (-s "$name.brackup" == $size || -s "$name.brackup.orig" == $size) {
+            debug("Skipping $name; already have it");
+            next;
+        }
+        debug("Fetching $name");
         $target->get_backup($si->filename);
     }