Changeset 504

Timestamp:

06/25/08 00:00:59 (17 months ago)

Author:

ykerherve

Message:

Fixed an issue in the case of a transaction involving different classes using same drivers.
Each $driver stores the same $dbh returned by DBIRole (in our case) but at the end of
the transaction we forget to remove the stashed copy of $dbh in the lasts drivers processed.
So at the beginning of the next transaction the $dbh choke because of the attributes of
the cached $dbh don't match what we're trying to do.

Another patch is on his way for a more streamlined transaction processing. (waiting reviews)

BugzID: 72971

Files:

• trunk/lib/Data/ObjectDriver/Driver/DBI.pm (modified) (1 diff)

trunk/lib/Data/ObjectDriver/Driver/DBI.pm

@@ -556 +556 @@
         or Carp::croak("$action called without a stored handle--begin_work?");
 
-    return if $dbh->{AutoCommit};
-
-    eval { $dbh->$action() };
-    if ($@) {
-        Carp::croak("$action failed for driver $driver: $@");
+    unless ($dbh->{AutoCommit}) {
+        eval { $dbh->$action() };
+        if ($@) {
+            Carp::croak("$action failed for driver $driver: $@");
+        }
     }
     if ($driver->{__delete_dbh_after_txn}) {