Changeset 175

Timestamp:

05/04/06 00:16:33 (4 years ago)

Author:

sky

Message:

r178@crucially-3 (orig r1212): btrott | 2006-04-13 10:22:42 -0700
There's an edge case where we don't get exactly back the number of
items that we requested from the cache, BUT we don't need to get any
more. Very strange. But anyway, this was causing us to give
DBI->lookup_multi an empty array ref of PKs, which generates mangled
SQL. This patch fixes that.

Files:

• trunk/lib/Data/ObjectDriver/Driver/BaseCache.pm (modified) (1 diff)

trunk/lib/Data/ObjectDriver/Driver/BaseCache.pm

@@ -107 +107 @@
     }
 
-    my $more = $driver->fallback->lookup_multi($class, \@need);
-    $i = 0;
-    for my $obj (@$more) {
-        $got[ $need2got{$i++} ] = $obj;
+    if (@need) {
+        my $more = $driver->fallback->lookup_multi($class, \@need);
+        $i = 0;
+        for my $obj (@$more) {
+            $got[ $need2got{$i++} ] = $obj;
+        }
     }