Changeset 164

Timestamp:

05/04/06 00:15:17 (4 years ago)

Author:

sky

Message:

r167@crucially-3 (orig r1198): ykerherve | 2006-04-06 06:41:36 -0700
Created a new changed_cols_and_pk() method on the object
and update the behaviour of changed_cols() to by default exclude PKs

Location:

branches/archetype-0.4/lib/Data/ObjectDriver

Files:

• BaseObject.pm (modified) (2 diffs)
• Driver/DBI.pm (modified) (1 diff)

branches/archetype-0.4/lib/Data/ObjectDriver/BaseObject.pm

@@ -186 +186 @@
 }
 
+sub changed_cols_and_pk {
+    my $obj = shift;
+    keys %{$obj->{changed_cols}};
+}
+
 sub changed_cols {
     my $obj = shift;
-    keys %{$obj->{changed_cols}};
+    my $pk = $obj->primary_key_tuple;
+    my %pk = map { $_ => 1 } @$pk;
+    grep !$pk{$_}, $obj->changed_cols_and_pk;
 }
 
@@ -196 +203 @@
         return exists $obj->{changed_cols}->{$_[0]};
     } else {
-        my $pk = $obj->primary_key_tuple;
-        my %pk = map { $_ => 1 } @$pk;
-        my @changed_cols = grep !$pk{$_}, $obj->changed_cols;
-        return @changed_cols > 0;
+        return $obj->changed_cols > 0;
     }
 }

branches/archetype-0.4/lib/Data/ObjectDriver/Driver/DBI.pm

@@ -296 +296 @@
 
     my $cols = $obj->column_names;
-    my $pk = $obj->primary_key_tuple;
-    my %pk = map { $_ => 1 } @$pk;
-    my @changed_cols = grep !$pk{$_}, $obj->changed_cols;
+    my @changed_cols = $obj->changed_cols;
 
     ## If there's no updated columns, update() is no-op