Changeset 104

Timestamp:

05/04/06 00:08:26 (4 years ago)

Author:

sky

Message:

r107@crucially-3 (orig r1091): ykerherve | 2006-02-02 19:19:28 -0800
Let's also croak for column('inexistent')

Location:

trunk

Files:

• lib/Data/ObjectDriver/BaseObject.pm (modified) (1 diff)
• t/02-basic.t (modified) (2 diffs)

trunk/lib/Data/ObjectDriver/BaseObject.pm

@@ -117 +117 @@
 sub column_values { $_[0]->{'column_values'} }
 
+## In 0.1 version we didn't die on inexistent column
+## which might lead to silent bugs
+## You should override column if you want to find the old 
+## behaviour
 sub column {
     my $obj = shift;
     my $col = shift or return;
+    unless ($obj->has_column($col)) {
+        Carp::croak("Cannot find column '$col' for class '" . ref($obj) . "'");
+    }
     $obj->{column_values}->{$col} = shift if @_;
     $obj->{column_values}->{$col};

trunk/t/02-basic.t

@@ -19 +19 @@
 }
 
-plan tests => 22;
+plan tests => 23;
 
 use Wine;
@@ -35 +35 @@
     ok $w->has_column("name");
     ok ! $w->has_column("inexistent");
-    dies_ok { $w->inexistent("hell") } "dies on setting inexistent column";
+    dies_ok { $w->inexistent("hell") } "dies on setting inexistent column : 'inexistent()'";
+    dies_ok { $w->column('inexistent') } "dies on setting inexistent column : 'column()'";
 }